[
https://issues.apache.org/jira/browse/HBASE-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135810#comment-13135810
]
[email protected] commented on HBASE-4669:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2568/#review2852
-----------------------------------------------------------
/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java
<https://reviews.apache.org/r/2568/#comment6386>
Please add enclosing curly braces for line 179.
/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
<https://reviews.apache.org/r/2568/#comment6387>
I think setting "hbase.master.enabletable.roundrobin" should be done in
this method.
- Ted
On 2011-10-26 06:51:56, Jieshan Bean wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2568/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-26 06:51:56)
bq.
bq.
bq. Review request for Ted Yu, Michael Stack and ramkrishna vasudevan.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Under some scenarios, we use the function of disable/enable HTable. But
currently, enable HTable uses the random-assignment. We hope all the regions
show a better distribution, no matter how many regions and how many
regionservers.
bq.
bq. So I suggest to add an option of using round-robin assignment on
enable-table.
bq.
bq.
bq. This addresses bug HBASE-4669.
bq. https://issues.apache.org/jira/browse/HBASE-4669
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
1188986
bq. /src/main/java/org/apache/hadoop/hbase/master/BulkAssigner.java 1188986
bq. /src/main/java/org/apache/hadoop/hbase/master/BulkReOpen.java 1188986
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java
1188986
bq. /src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 1188986
bq.
bq. Diff: https://reviews.apache.org/r/2568/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Jieshan
bq.
bq.
> Add an option of using round-robin assignment for enabling table
> ----------------------------------------------------------------
>
> Key: HBASE-4669
> URL: https://issues.apache.org/jira/browse/HBASE-4669
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.90.4, 0.94.0
> Reporter: Jieshan Bean
> Priority: Minor
> Fix For: 0.94.0, 0.90.5
>
> Attachments: HBASE-4669-90.patch, HBASE-4669-Trunk-V2.patch,
> HBASE-4669-Trunk.patch
>
>
> Under some scenarios, we use the function of disable/enable HTable. But
> currently, enable HTable uses the random-assignment. We hope all the regions
> show a better distribution, no matter how many regions and how many
> regionservers.
> So I suggest to add an option of using round-robin assignment on
> enable-table.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
