[
https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138792#comment-13138792
]
Jonathan Gray commented on HBASE-4641:
--------------------------------------
I like v4 much less than the other changes. My v1 patch makes it so we could
potentially break something because it's expecting to be able to manipulate the
conf after construction (an easy assumption to document / test for). The v4
patch now takes the conf passed in by reference and modifies it. It then
modifies the same conf reference later in Store. Seems like this could have
some bad side-effects in the opposite direction.
At this point, I vote for the v1 hack until we make the cache non-static. As
long as unit tests still pass.
> Block cache can be mistakenly instantiated on Master
> ----------------------------------------------------
>
> Key: HBASE-4641
> URL: https://issues.apache.org/jira/browse/HBASE-4641
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Jonathan Gray
> Assignee: Ted Yu
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4641-suggestion-v3.txt, 4641-v4.txt,
> HBASE-4641-v1.patch, HBASE-4641-v2.patch
>
>
> After changes in the block cache instantiation over in HBASE-4422, it looks
> like the HMaster can now end up with a block cache instantiated. Not a huge
> deal but prevents the process from shutting down properly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
