[
https://issues.apache.org/jira/browse/HBASE-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139462#comment-13139462
]
stack commented on HBASE-4641:
------------------------------
Smile. Seems like two of us are voting for v4 but v1 gets committed.
Issues w/ v1:
+ imports a class from a subpackage that is one up and then two subpackages
down in the package hierarchy; makes for bad package cohesion.
+ The first thing done on Construction of the master is some wonky cache-size
setting; its hard to grok whats going on and why this is first thing we're
doing constructing an HMaster instance (comment could be better why we are up
to such pervertions).
+ We clone a Configuration.
v4 should have a better comment on what its about and that its dependent on how
minihbasecluster currently has a Configuration per Server (which is needed for
lots of reasons such as Connections and User in Security so its fine depending
on this behavior) but v4 has the merit of going from the general -- I'm a
Master Configuration (which could be leveraged in other ways than whats needed
here) -- to the specific down in HStore when it starts to mess with Cache.
I'd say leave things as is. v1 will work for now. Its going to change when
the CacheConfig stuff gets a refactoring.
> Block cache can be mistakenly instantiated on Master
> ----------------------------------------------------
>
> Key: HBASE-4641
> URL: https://issues.apache.org/jira/browse/HBASE-4641
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4641-suggestion-v3.txt, 4641-v4.txt,
> HBASE-4641-v1.patch, HBASE-4641-v2.patch
>
>
> After changes in the block cache instantiation over in HBASE-4422, it looks
> like the HMaster can now end up with a block cache instantiated. Not a huge
> deal but prevents the process from shutting down properly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
