[
https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139022#comment-13139022
]
Phabricator commented on HBASE-4698:
------------------------------------
mbautin has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty
Printer print all the key values for a specific row.".
A few comments inline:
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:137
What happens otherwise? I think we need to display an error message and
terminate if the parameter is not specified.
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:239 Is
row just the row or the key portion of the KV, as the call suggests? If the
latter, it is not clear to me how we get an exact match on the row.
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:256-257
If we did not do a seekTo, this would produce a message for every row scanned
before the row of interest. Does it make sense to move the message out of the
loop?
REVISION DETAIL
https://reviews.facebook.net/D111
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and
> only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
