[
https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140699#comment-13140699
]
Phabricator commented on HBASE-4698:
------------------------------------
Liyin has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty
Printer print all the key values for a specific row.".
Thanks Mikhail's and Nicolas's review and response the comments inline.
I will update the diff to address the comments.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:70 I
used the Eclipse code formatter to format the code here, which is based on the
hbase code style mentioned in HBase book.
http://hbase.apache.org/book.html#eclipse
However, there is no rule saying I have to add an empty line here.
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:251
Good point:) thanks a lot. I will update this.
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:253 I
don't understand why this line is NOT necessary.
This function DOES throw out IOException, doesn't it?
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:247
Why I need to remove this line?
According to the code format from the HBase book, there is no need to remove
empty line in the java doc:
HBase book:
http://hbase.apache.org/book.html#eclipse
The setting:
<setting
id="org.eclipse.jdt.core.formatter.comment.clear_blank_lines_in_javadoc_comment"
value="false"/>
REVISION DETAIL
https://reviews.facebook.net/D111
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch, D111.2.patch,
> D111.3.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and
> only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
