[ https://issues.apache.org/jira/browse/HBASE-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139816#comment-13139816 ]
Ted Yu commented on HBASE-4703: ------------------------------- I got the following test failures for the attached patch. These two failed both in test suite and individually. {code} testFlushCommitsWithAbort(org.apache.hadoop.hbase.client.TestMultiParallel) Time elapsed: 45.25 sec <<< ERROR! java.io.IOException: HRegionInfo was null or empty in .META., row=keyvalues={multi_test_table,ddd,1320006349447.09bf3a7042e4b84494f49b21d8e6f771./info:server/1320006349957/Put/vlen=19, multi_test_table,ddd,1320006349447.09bf3a7042e4b84494f49b21d8e6f771./info:serverstartcode/1320006349957/Put/vlen=8} at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegionInMeta(HConnectionManager.java:908) at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(HConnectionManager.java:769) at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.processBatchCallback(HConnectionManager.java:1429) at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.processBatch(HConnectionManager.java:1314) at org.apache.hadoop.hbase.client.HTable.flushCommits(HTable.java:878) at org.apache.hadoop.hbase.client.TestMultiParallel.doTestFlushCommits(TestMultiParallel.java:240) at org.apache.hadoop.hbase.client.TestMultiParallel.testFlushCommitsWithAbort(TestMultiParallel.java:207) {code} {code} testThreeRSAbort(org.apache.hadoop.hbase.master.TestDistributedLogSplitting) Time elapsed: 91.605 sec <<< FAILURE! java.lang.AssertionError: at org.junit.Assert.fail(Assert.java:91) at org.junit.Assert.assertTrue(Assert.java:43) at org.junit.Assert.assertTrue(Assert.java:54) at org.apache.hadoop.hbase.master.TestDistributedLogSplitting.testThreeRSAbort(TestDistributedLogSplitting.java:139) {code} The following failed in test suite but succeeded individually: {code} testMasterFailoverWithMockedRITOnDeadRS(org.apache.hadoop.hbase.master.TestMasterFailover) Time elapsed: 180.011 sec <<< ERROR! java.lang.Exception: test timed out after 180000 milliseconds at java.lang.Thread.sleep(Native Method) at org.apache.hadoop.hbase.MiniHBaseCluster.waitForActiveAndReadyMaster(MiniHBaseCluster.java:385) at org.apache.hadoop.hbase.master.TestMasterFailover.testMasterFailoverWithMockedRITOnDeadRS(TestMasterFailover.java:923) {code} {code} testRowRange(org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol) Time elapsed: 0.037 sec <<< FAILURE! java.lang.AssertionError: Results should contain region test,ccc,1320009243019.ffa363645a679c2c4caf69ede87bdfe3. for row 'ccc' at org.junit.Assert.fail(Assert.java:91) at org.junit.Assert.assertTrue(Assert.java:43) at org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol.verifyRegionResults(TestServerCustomProtocol.java:335) at org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol.verifyRegionResults(TestServerCustomProtocol.java:327) at org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol.testRowRange(TestServerCustomProtocol.java:213) {code} > Improvements in tests > --------------------- > > Key: HBASE-4703 > URL: https://issues.apache.org/jira/browse/HBASE-4703 > Project: HBase > Issue Type: Improvement > Components: test > Affects Versions: 0.92.0 > Environment: all > Reporter: nkeywal > Assignee: nkeywal > Priority: Minor > Attachments: 20111030_4703_all.patch, 20111030_4703_all.v2.patch > > > Global: > - when possible, make the test using the default cluster configuration for > the number of region (1 instead of 2 or 3). This allows a faster stop/start, > and is a step toward a shared cluster configuration. > - 'sleep': lower or remove the sleep based synchronisation in the tests (in > HBaseTestingUtility, TestGlobalMemStoreSize, TestAdmin, > TestCoprocessorEndpoint, TestHFileOutputFormat, TestLruBlockCache, > TestServerCustomProtocol, TestReplicationSink) > - Optimize 'put' by setting setWriteToWAL to false, when the 'put' is big > or in a loop. Not done for tests that rely on the WAL. > > Local issues: > - TestTableInputFormatScan fully deletes the hadoop.tmp.dir directory on > tearDown, that makes it impossible to use in // with another test using this > directory > - TestIdLock logs too much (9000 lines per seconds). Test time lowered to 15 > seconds to make it a part of the small subset > - TestMemoryBoundedLogMessageBuffer useless System.out.println > - io.hfile.TestReseekTo useless System.out.println > - TestTableInputFormat does not shutdown the cluster > - testGlobalMemStore does not shutdown the cluster > - rest.client.TestRemoteAdmin: simplified, does not use local admin, single > test instead of two. > - HBaseTestingUtility#ensureSomeRegionServersAvailable starts only one > server, should start the number of missing server instead. > - TestMergeTool should starts/stops the dfs cluster with HBaseTestingUtility -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira