[ https://issues.apache.org/jira/browse/HBASE-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140210#comment-13140210 ]
nkeywal commented on HBASE-4703: -------------------------------- I've managed to reproduce the stack on testRowRange(org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol; after more than 10 tries. I am going to revert my change on this file. I haven't been able to reproduce the others (two are caused by a java.io.IOException: Too many open files). I had a stack on testWorkerAbort(org.apache.hadoop.hbase.master.TestDistributedLogSplitting), but it's a stack I've already seen without this patch, so I don't think it's related. {noformat} testWorkerAbort(org.apache.hadoop.hbase.master.TestDistributedLogSplitting) Time elapsed: 231.598 sec <<< FAILURE! java.lang.AssertionError: expected:<1> but was:<0> at org.junit.Assert.fail(Assert.java:91) at org.junit.Assert.failNotEquals(Assert.java:645) at org.junit.Assert.assertEquals(Assert.java:126) at org.junit.Assert.assertEquals(Assert.java:470) at org.junit.Assert.assertEquals(Assert.java:454) at org.apache.hadoop.hbase.master.TestDistributedLogSplitting.testWorkerAbort(TestDistributedLogSplitting.java:294) {noformat} > Improvements in tests > --------------------- > > Key: HBASE-4703 > URL: https://issues.apache.org/jira/browse/HBASE-4703 > Project: HBase > Issue Type: Improvement > Components: test > Affects Versions: 0.92.0 > Environment: all > Reporter: nkeywal > Assignee: nkeywal > Priority: Minor > Attachments: 20111030_4703_all.patch, 20111030_4703_all.v2.patch, > 20111030_4703_all.v3.patch, 20111030_4703_all.v4.patch > > > Global: > - when possible, make the test using the default cluster configuration for > the number of region (1 instead of 2 or 3). This allows a faster stop/start, > and is a step toward a shared cluster configuration. > - 'sleep': lower or remove the sleep based synchronisation in the tests (in > HBaseTestingUtility, TestGlobalMemStoreSize, TestAdmin, > TestCoprocessorEndpoint, TestHFileOutputFormat, TestLruBlockCache, > TestServerCustomProtocol, TestReplicationSink) > - Optimize 'put' by setting setWriteToWAL to false, when the 'put' is big > or in a loop. Not done for tests that rely on the WAL. > > Local issues: > - TestTableInputFormatScan fully deletes the hadoop.tmp.dir directory on > tearDown, that makes it impossible to use in // with another test using this > directory > - TestIdLock logs too much (9000 lines per seconds). Test time lowered to 15 > seconds to make it a part of the small subset > - TestMemoryBoundedLogMessageBuffer useless System.out.println > - io.hfile.TestReseekTo useless System.out.println > - TestTableInputFormat does not shutdown the cluster > - testGlobalMemStore does not shutdown the cluster > - rest.client.TestRemoteAdmin: simplified, does not use local admin, single > test instead of two. > - HBaseTestingUtility#ensureSomeRegionServersAvailable starts only one > server, should start the number of missing server instead. > - TestMergeTool should starts/stops the dfs cluster with HBaseTestingUtility -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira