[ https://issues.apache.org/jira/browse/HBASE-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015044#comment-15015044 ]
Jonathan Hsieh commented on HBASE-14829: ---------------------------------------- [~saint....@gmail.com], actually, checkstyle test (HBASE-12261) is actually pretty smart now -- it runs before and runs after and does a delta. We could probably tweak it a little more to display what the checkstyle delta is. (same goes for findbugs after HBASE-13334) > Add more checkstyles > -------------------- > > Key: HBASE-14829 > URL: https://issues.apache.org/jira/browse/HBASE-14829 > Project: HBase > Issue Type: Improvement > Reporter: Appy > Assignee: Appy > Attachments: HBASE-14829-master-v2.patch, > HBASE-14829-master-v2.patch, HBASE-14829-master.patch > > > This jira will add following checkstyles: > [ImportOrder|http://checkstyle.sourceforge.net/config_imports.html#ImportOrder] > : keep imports in sorted order > [LeftCurly|http://checkstyle.sourceforge.net/config_blocks.html#LeftCurly] : > Placement of left curly brace. Does 'eol' sounds right setting? > [NeedBraces|http://checkstyle.sourceforge.net/config_blocks.html#NeedBraces] > : braces around code blocks > [JavadocTagContinuationIndentation|http://checkstyle.sourceforge.net/config_javadoc.html#JavadocTagContinuationIndentation] > : Avoid weird indentations in javadocs > [NonEmptyAtclauseDescription|http://checkstyle.sourceforge.net/config_javadoc.html#NonEmptyAtclauseDescription] > : We have sooooo many empty javadoc @ clauses. This'll take care of it. > > [Indentation|http://checkstyle.sourceforge.net/config_misc.html#Indentation] > : Bad indentation hurts code readability. We have indentation guidelines, > should be fine enforcing them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)