[
https://issues.apache.org/jira/browse/HBASE-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018997#comment-15018997
]
Appy commented on HBASE-14829:
------------------------------
[~jmhsieh] HBASE-14859 will make checkstyling smarter. Instead of seeing
pre-patch/post-patch counts, it'll check for each file, if count of any error
type increased. It'll also print culprit filenames and error types.
> Add more checkstyles
> --------------------
>
> Key: HBASE-14829
> URL: https://issues.apache.org/jira/browse/HBASE-14829
> Project: HBase
> Issue Type: Improvement
> Reporter: Appy
> Assignee: Appy
> Fix For: 2.0.0
>
> Attachments: HBASE-14829-master-v2.patch,
> HBASE-14829-master-v2.patch, HBASE-14829-master.patch
>
>
> This jira will add following checkstyles:
> [ImportOrder|http://checkstyle.sourceforge.net/config_imports.html#ImportOrder]
> : keep imports in sorted order
> [LeftCurly|http://checkstyle.sourceforge.net/config_blocks.html#LeftCurly] :
> Placement of left curly brace. Does 'eol' sounds right setting?
> [NeedBraces|http://checkstyle.sourceforge.net/config_blocks.html#NeedBraces]
> : braces around code blocks
> [JavadocTagContinuationIndentation|http://checkstyle.sourceforge.net/config_javadoc.html#JavadocTagContinuationIndentation]
> : Avoid weird indentations in javadocs
> [NonEmptyAtclauseDescription|http://checkstyle.sourceforge.net/config_javadoc.html#NonEmptyAtclauseDescription]
> : We have sooooo many empty javadoc @ clauses. This'll take care of it.
>
> [Indentation|http://checkstyle.sourceforge.net/config_misc.html#Indentation]
> : Bad indentation hurts code readability. We have indentation guidelines,
> should be fine enforcing them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
