[
https://issues.apache.org/jira/browse/HBASE-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056077#comment-15056077
]
Hudson commented on HBASE-14936:
--------------------------------
FAILURE: Integrated in HBase-1.3 #434 (See
[https://builds.apache.org/job/HBase-1.3/434/])
HBASE-14936 CombinedBlockCache should overwrite (chenheng: rev
3b9b8cc667d3a7ffb3473ac8f181f27cff8c1a4e)
*
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCombinedBlockCache.java
> CombinedBlockCache should overwrite CacheStats#rollMetricsPeriod()
> ------------------------------------------------------------------
>
> Key: HBASE-14936
> URL: https://issues.apache.org/jira/browse/HBASE-14936
> Project: HBase
> Issue Type: Bug
> Components: BlockCache
> Affects Versions: 1.1.2
> Reporter: Jianwei Cui
> Assignee: Jianwei Cui
> Fix For: 2.0.0, 1.2, 1.1, 1.3, 1.0
>
> Attachments: HBASE-14936-branch-1.0-1.1.patch,
> HBASE-14936-branch-1.0-addendum.patch, HBASE-14936-trunk-v1.patch,
> HBASE-14936-trunk-v2.patch, HBASE-14936-trunk.patch
>
>
> It seems CombinedBlockCache should overwrite CacheStats#rollMetricsPeriod() as
> {code}
> public void rollMetricsPeriod() {
> lruCacheStats.rollMetricsPeriod();
> bucketCacheStats.rollMetricsPeriod();
> }
> {code}
> otherwise, CombinedBlockCache.getHitRatioPastNPeriods() and
> CombinedBlockCache.getHitCachingRatioPastNPeriods() will always return 0.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
