[ https://issues.apache.org/jira/browse/HBASE-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056415#comment-15056415 ]
Hudson commented on HBASE-14936: -------------------------------- FAILURE: Integrated in HBase-1.1-JDK8 #1706 (See [https://builds.apache.org/job/HBase-1.1-JDK8/1706/]) HBASE-14936 CombinedBlockCache should overwrite (chenheng: rev b7b9123e758d1d6b35651212a4d1a14521eb1606) * hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCombinedBlockCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java HBASE-14936 CombinedBlockCache should overwrite (chenheng: rev d6000a8a611abe016e57e6575092e392c508aeaa) * hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java > CombinedBlockCache should overwrite CacheStats#rollMetricsPeriod() > ------------------------------------------------------------------ > > Key: HBASE-14936 > URL: https://issues.apache.org/jira/browse/HBASE-14936 > Project: HBase > Issue Type: Bug > Components: BlockCache > Affects Versions: 1.1.2 > Reporter: Jianwei Cui > Assignee: Jianwei Cui > Fix For: 2.0.0, 1.2, 1.1, 1.3, 1.0 > > Attachments: HBASE-14936-branch-1.0-1.1.patch, > HBASE-14936-branch-1.0-addendum.patch, HBASE-14936-trunk-v1.patch, > HBASE-14936-trunk-v2.patch, HBASE-14936-trunk.patch > > > It seems CombinedBlockCache should overwrite CacheStats#rollMetricsPeriod() as > {code} > public void rollMetricsPeriod() { > lruCacheStats.rollMetricsPeriod(); > bucketCacheStats.rollMetricsPeriod(); > } > {code} > otherwise, CombinedBlockCache.getHitRatioPastNPeriods() and > CombinedBlockCache.getHitCachingRatioPastNPeriods() will always return 0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)