[
https://issues.apache.org/jira/browse/HBASE-15027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085193#comment-15085193
]
Anoop Sam John commented on HBASE-15027:
----------------------------------------
The HStore.close() flow calls the processCompactedfiles(List) method which just
submit all files close to another thread. An async call and close flow not
waiting for this. Seems not correct. The close flow can close these compacted
away files and archive in a sync way?
The choreService which runs in every 2mins call a method on store and that
seems getting the Thread pool from RS and submit a new job. Can we just change
it like that the CHoreService loop only will create a handler job for the pool
and within the job u call the store method closeAndArchiveCompactedFiles? So
HStore wont have any async way of close of files at all. You can use same
method for STore close flow also.
> Refactor the way the CompactedHFileDischarger threads are created
> -----------------------------------------------------------------
>
> Key: HBASE-15027
> URL: https://issues.apache.org/jira/browse/HBASE-15027
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-15027.patch, HBASE-15027_1.patch,
> HBASE-15027_2.patch, HBASE-15027_3.patch, HBASE-15027_3.patch,
> HBASE-15027_4.patch, HBASE-15027_5.patch
>
>
> As per suggestion given over in HBASE-14970, if we need to create a single
> thread pool service for the CompactionHFileDischarger we need to create an
> exectuor service in the RegionServer level and create discharger handler
> threads (Event handlers) and pass the Event to the new Exectuor service that
> we create for the compaction hfiles discharger. What should be the default
> number of threads here? If a HRS holds 100 of regions - will 10 threads be
> enough? This issue will try to resolve this with tests and discussions and
> suitable patch will be updated in HBASE-14970 for branch-1 once this is
> committed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
