[ https://issues.apache.org/jira/browse/HBASE-14703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199514#comment-15199514 ]
Hadoop QA commented on HBASE-14703: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 5 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 9s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 46s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 58s {color} | {color:green} branch-1 passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 5s {color} | {color:green} branch-1 passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 7s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 10s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 1m 54s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 10m 16s {color} | {color:green} branch-1 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 23s {color} | {color:green} branch-1 passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 14s {color} | {color:green} branch-1 passed with JDK v1.7.0_79 {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 14s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 28s {color} | {color:green} the patch passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 6m 28s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 11m 58s {color} | {color:red} hbase-server-jdk1.8.0 with JDK v1.8.0 generated 6 new + 6 unchanged - 0 fixed = 12 total (was 6) {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 11m 58s {color} | {color:red} hbase-server-jdk1.8.0 with JDK v1.8.0 generated 6 new + 6 unchanged - 0 fixed = 12 total (was 6) {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 28s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 51s {color} | {color:green} the patch passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 3m 51s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 15m 50s {color} | {color:red} hbase-server-jdk1.7.0_79 with JDK v1.7.0_79 generated 6 new + 6 unchanged - 0 fixed = 12 total (was 6) {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 15m 50s {color} | {color:red} hbase-server-jdk1.7.0_79 with JDK v1.7.0_79 generated 6 new + 6 unchanged - 0 fixed = 12 total (was 6) {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 51s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 34s {color} | {color:green} hbase-protocol: patch generated 0 new + 0 unchanged - 83 fixed = 0 total (was 83) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 33s {color} | {color:green} hbase-protocol: patch generated 0 new + 0 unchanged - 83 fixed = 0 total (was 83) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 33s {color} | {color:green} hbase-client: patch generated 0 new + 0 unchanged - 83 fixed = 0 total (was 83) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 41s {color} | {color:green} hbase-client: patch generated 0 new + 0 unchanged - 83 fixed = 0 total (was 83) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 36s {color} | {color:green} hbase-server: patch generated 0 new + 0 unchanged - 83 fixed = 0 total (was 83) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 35s {color} | {color:green} hbase-server: patch generated 0 new + 0 unchanged - 83 fixed = 0 total (was 83) {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 42s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s {color} | {color:red} The patch has 17 line(s) that end in whitespace. Use git apply --whitespace=fix. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 21m 10s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 3m 36s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 17m 58s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 7m 47s {color} | {color:red} hbase-client-jdk1.8.0 with JDK v1.8.0 generated 12 new + 12 unchanged - 0 fixed = 24 total (was 12) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 7m 47s {color} | {color:red} hbase-client-jdk1.8.0 with JDK v1.8.0 generated 12 new + 12 unchanged - 0 fixed = 24 total (was 12) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 7m 47s {color} | {color:red} hbase-server-jdk1.8.0 with JDK v1.8.0 generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 7m 47s {color} | {color:red} hbase-server-jdk1.8.0 with JDK v1.8.0 generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 18s {color} | {color:green} the patch passed with JDK v1.8.0 {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 11m 8s {color} | {color:red} hbase-client-jdk1.7.0_79 with JDK v1.7.0_79 generated 12 new + 12 unchanged - 0 fixed = 24 total (was 12) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 11m 8s {color} | {color:red} hbase-client-jdk1.7.0_79 with JDK v1.7.0_79 generated 12 new + 12 unchanged - 0 fixed = 24 total (was 12) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 11m 8s {color} | {color:red} hbase-server-jdk1.7.0_79 with JDK v1.7.0_79 generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 11m 8s {color} | {color:red} hbase-server-jdk1.7.0_79 with JDK v1.7.0_79 generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 21s {color} | {color:green} the patch passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 31s {color} | {color:green} hbase-protocol in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 30s {color} | {color:green} hbase-protocol in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 8s {color} | {color:green} hbase-client in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 8s {color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 226m 36s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 2m 15s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 5m 1s {color} | {color:green} Patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 346m 16s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Timed out junit tests | org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay | | | org.apache.hadoop.hbase.regionserver.wal.TestWALReplay | | | org.apache.hadoop.hbase.filter.TestFilterWithScanLimits | | | org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss | | | org.apache.hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleWAL | | | org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot | | | org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint | | | org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint | | | org.apache.hadoop.hbase.snapshot.TestExportSnapshot | | | org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache | | | org.apache.hadoop.hbase.TestIOFencing | | | org.apache.hadoop.hbase.regionserver.TestHRegion | | | org.apache.hadoop.hbase.replication.TestReplicationKillMasterRS | | | org.apache.hadoop.hbase.TestMetaTableAccessor | | | org.apache.hadoop.hbase.regionserver.wal.TestWALReplayCompressed | | | org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay | | | org.apache.hadoop.hbase.regionserver.wal.TestWALReplay | | | org.apache.hadoop.hbase.filter.TestFilterWithScanLimits | | | org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss | | | org.apache.hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleWAL | | | org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot | | | org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint | | | org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint | | | org.apache.hadoop.hbase.snapshot.TestExportSnapshot | | | org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache | | | org.apache.hadoop.hbase.TestIOFencing | | | org.apache.hadoop.hbase.regionserver.TestHRegion | | | org.apache.hadoop.hbase.replication.TestReplicationKillMasterRS | | | org.apache.hadoop.hbase.TestMetaTableAccessor | | | org.apache.hadoop.hbase.regionserver.wal.TestWALReplayCompressed | \\ \\ || Subsystem || Report/Notes || | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12793924/HBASE-14703-branch-1.v1.patch | | JIRA Issue | HBASE-14703 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc | | uname | Linux asf911.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh | | git revision | branch-1 / a06994b | | Default Java | 1.7.0_79 | | Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 | | findbugs | v3.0.0 | | javac | hbase-server-jdk1.8.0: https://builds.apache.org/job/PreCommit-HBASE-Build/1039/artifact/patchprocess/diff-compile-javac-hbase-server-jdk1.8.0.txt | | javac | hbase-server-jdk1.8.0: https://builds.apache.org/job/PreCommit-HBASE-Build/1039/artifact/patchprocess/diff-compile-javac-hbase-server-jdk1.8.0.txt | | javac | hbase-server-jdk1.7.0_79: https://builds.apache.org/job/PreCommit-HBASE-Build/1039/artifact/patchprocess/diff-compile-javac-hbase-server-jdk1.7.0_79.txt | | javac | hbase-server-jdk1.7.0_79: https://builds.apache.org/job/PreCommit-HBASE-Build/1039/artifact/patchprocess/diff-compile-javac-hbase-server-jdk1.7.0_79.txt | | whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/1039/artifact/patchprocess/whitespace-eol.txt | | javadoc | hbase-client-jdk1.8.0: https://builds.apache.org/job/PreCommit-HBASE-Build/1039/artifact/patchprocess/diff-javadoc-javadoc-hbase-client-jdk1.8.0.txt | | javadoc | hbase-client-jdk1.8.0: https://builds.apache.org/job/PreCommit-HBASE-Build/1039/artifact/patchprocess/diff-javadoc-javadoc-hbase-client-jdk1.8.0.txt | | javadoc | hbase-server-jdk1.8.0: https://builds.apache.org/job/PreCommit-HBASE-Build/1039/artifact/patchprocess/diff-javadoc-javadoc-hbase-server-jdk1.8.0.txt | | javadoc | hbase-server-jdk1.8.0: https://builds.apache.org/job/PreCommit-HBASE-Build/1039/artifact/patchprocess/diff-javadoc-javadoc-hbase-server-jdk1.8.0.txt | | javadoc | hbase-client-jdk1.7.0_79: https://builds.apache.org/job/PreCommit-HBASE-Build/1039/artifact/patchprocess/diff-javadoc-javadoc-hbase-client-jdk1.7.0_79.txt | | javadoc | hbase-client-jdk1.7.0_79: https://builds.apache.org/job/PreCommit-HBASE-Build/1039/artifact/patchprocess/diff-javadoc-javadoc-hbase-client-jdk1.7.0_79.txt | | javadoc | hbase-server-jdk1.7.0_79: https://builds.apache.org/job/PreCommit-HBASE-Build/1039/artifact/patchprocess/diff-javadoc-javadoc-hbase-server-jdk1.7.0_79.txt | | javadoc | hbase-server-jdk1.7.0_79: https://builds.apache.org/job/PreCommit-HBASE-Build/1039/artifact/patchprocess/diff-javadoc-javadoc-hbase-server-jdk1.7.0_79.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/1039/artifact/patchprocess/patch-unit-hbase-server.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/1039/artifact/patchprocess/patch-unit-hbase-server.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/1039/artifact/patchprocess/patch-unit-hbase-server.txt https://builds.apache.org/job/PreCommit-HBASE-Build/1039/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/1039/testReport/ | | modules | C: hbase-protocol hbase-protocol hbase-client hbase-client hbase-server hbase-server U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/1039/console | | Powered by | Apache Yetus 0.2.0 http://yetus.apache.org | This message was automatically generated. > HTable.mutateRow does not collect stats > --------------------------------------- > > Key: HBASE-14703 > URL: https://issues.apache.org/jira/browse/HBASE-14703 > Project: HBase > Issue Type: Improvement > Components: Client > Reporter: Heng Chen > Assignee: Heng Chen > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-14702_v5.2_addendum-addendum.patch, > HBASE-14703-5.2-addendum.patch, HBASE-14703-async.patch, > HBASE-14703-branch-1.patch, HBASE-14703-branch-1.v1.patch, > HBASE-14703-branch-1_v1.patch, HBASE-14703-start.patch, > HBASE-14703-v4.1.patch, HBASE-14703-v4.patch, > HBASE-14703-v6_with-check-and-mutate.patch, HBASE-14703.patch, > HBASE-14703_v1.patch, HBASE-14703_v10.patch, HBASE-14703_v10.patch, > HBASE-14703_v11.patch, HBASE-14703_v12.patch, HBASE-14703_v13.patch, > HBASE-14703_v2.patch, HBASE-14703_v3.patch, HBASE-14703_v5.1.patch, > HBASE-14703_v5.2.patch, HBASE-14703_v5.patch, HBASE-14703_v6-addendum.patch, > HBASE-14703_v6.patch, HBASE-14703_v7.patch, HBASE-14703_v8.patch, > HBASE-14703_v9.patch > > > We are trying to fix the stats implementation, by moving it out of the Result > object and into an Rpc payload (but not the 'cell payload', just as part of > the values returned from the request). This change will also us use easily > switch to AsyncProcess as the executor, and support stats, for nearly all the > rpc calls. However, that means when you upgrade the client or server, you > will lose stats visibility until the other side is upgraded. We could keep > around the Result based stats storage to accommodate the old api and send > both stats back from the server (in each result and in the rpc payload). > Note that we will still be wire compatible - protobufs mean we can just ride > over the lack of information. > The other tricky part of this is that Result has a > non-InterfaceAudience.Private getStatistics() method (along with two > InterfaceAudience.Private addResults and setStatistics methods), so we might > need a release to deprecate the getStats() method before throwing it out? -- This message was sent by Atlassian JIRA (v6.3.4#6332)