[ 
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213756#comment-15213756
 ] 

ramkrishna.s.vasudevan commented on HBASE-14921:
------------------------------------------------

bq.shallowCellsToBuffer
This method in the test and the corresponding code explains what really 
happens. It looks great.
So the CellBlockSerialized (I think we can have a better name) - will work only 
if the MSLAB Chunk pool is ON right?  If there is no MSLAB chunk pool still it 
can work?  I may be missing something.

Now the entire cellblock is just referred from the index creating using 3 
Integers. Great.
Now in  your shallowCellsToBuffer even the shallowBuffer is created with the 
same 'chunkSize' as we create the deepbuffer also?  Is that really needed?  
How does things work when the chunkpool gets reset and initialized? Will do one 
more process later this week. 

> Memory optimizations
> --------------------
>
>                 Key: HBASE-14921
>                 URL: https://issues.apache.org/jira/browse/HBASE-14921
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: Eshcar Hillel
>            Assignee: Anastasia Braginsky
>         Attachments: CellBlocksSegmentInMemStore.pdf, 
> CellBlocksSegmentinthecontextofMemStore(1).pdf, HBASE-14921-V01.patch, 
> HBASE-14921-V02.patch
>
>
> Memory optimizations including compressed format representation and offheap 
> allocations



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to