[ https://issues.apache.org/jira/browse/HBASE-15093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229371#comment-15229371 ]
Hadoop QA commented on HBASE-15093: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s {color} | {color:red} HBASE-15093 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.2.0/precommit-patchnames for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12797413/HBASE-15093-V1.patch | | JIRA Issue | HBASE-15093 | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/1314/console | | Powered by | Apache Yetus 0.2.0 http://yetus.apache.org | This message was automatically generated. > Replication can report incorrect size of log queue for the global source when > multiwal is enabled > ------------------------------------------------------------------------------------------------- > > Key: HBASE-15093 > URL: https://issues.apache.org/jira/browse/HBASE-15093 > Project: HBase > Issue Type: Bug > Components: Replication > Affects Versions: 2.0.0, 1.2.0, 1.2.1 > Reporter: Ashu Pachauri > Assignee: Ashu Pachauri > Priority: Minor > Attachments: HBASE-15093-V0.patch, HBASE-15093-V1.patch, > HBASE-15093-V1.patch > > > Replication can report incorrect size for the size of log queue for the > global source when multiwal is enabled. This happens because the method > MetricsSource#setSizeofLogQueue performs non-trivial operations in a > multithreaded world, even though it is not synchronized. > We can simply divide MetricsSource#setSizeofLogQueue into > MetricsSource#incrSizeofLogQueue and MetricsSource#decrSizeofLogQueue. Not > sure why we are currently directly setting the size instead of > incrementing/decrementing it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)