[
https://issues.apache.org/jira/browse/HBASE-15093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235646#comment-15235646
]
Hudson commented on HBASE-15093:
--------------------------------
FAILURE: Integrated in HBase-1.3 #643 (See
[https://builds.apache.org/job/HBase-1.3/643/])
HBASE-15093 Replication can report incorrect size of log queue for the (tedyu:
rev 9473ab4bace61e9ca6f75fa4d0edb32d1b8d417e)
*
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSource.java
*
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java
*
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSource.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSource.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
> Replication can report incorrect size of log queue for the global source when
> multiwal is enabled
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-15093
> URL: https://issues.apache.org/jira/browse/HBASE-15093
> Project: HBase
> Issue Type: Bug
> Components: Replication
> Affects Versions: 2.0.0, 1.2.0, 1.2.1
> Reporter: Ashu Pachauri
> Assignee: Ashu Pachauri
> Priority: Minor
> Fix For: 2.0.0, 1.3.0, 1.4.0
>
> Attachments: HBASE-15093-V0.patch, HBASE-15093-V1.patch,
> HBASE-15093-V1.patch, HBASE-15093-V2.patch
>
>
> Replication can report incorrect size for the size of log queue for the
> global source when multiwal is enabled. This happens because the method
> MetricsSource#setSizeofLogQueue performs non-trivial operations in a
> multithreaded world, even though it is not synchronized.
> We can simply divide MetricsSource#setSizeofLogQueue into
> MetricsSource#incrSizeofLogQueue and MetricsSource#decrSizeofLogQueue. Not
> sure why we are currently directly setting the size instead of
> incrementing/decrementing it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
