[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243995#comment-15243995
]
stack commented on HBASE-14921:
-------------------------------
On patch....
This is still in here:
* CellArrayMap is a simple array of Cells and can be allocated only
using JVM.
How can something called CellArrayMap be an array of Cells? Whats 'Map' doing
in there? It implements Map, so be nicer to Maps in your description ? (smile)
And 'only using JVM'... what else? You mean 'on heap'?
We pass comparator on construction and in createSubCellFlatMap? We need it in
both places? The cell array is ordered? Why we need a comparator if it already
ordered?
When getCell, we should check the boundaries... the min and max.
It is odd that CellFlatMap implements ConcurrentNavigableMap but...
37 * The CellFlatMap uses no synchronization primitives, it is assumed to
be created by a
38 * single thread and then it can be read-only by multiple threads.
The parent ImmutableSegment has to know its subclasses? The enums?
Can this be a CellScanner?
public class MemStoreCompactorIterator implements Iterator<Cell> {
Will be back with closer review... but looks good.
> Memory optimizations
> --------------------
>
> Key: HBASE-14921
> URL: https://issues.apache.org/jira/browse/HBASE-14921
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Eshcar Hillel
> Assignee: Anastasia Braginsky
> Attachments: CellBlocksSegmentInMemStore.pdf,
> CellBlocksSegmentinthecontextofMemStore(1).pdf, HBASE-14921-V01.patch,
> HBASE-14921-V02.patch, HBASE-14921-V03.patch,
> IntroductiontoNewFlatandCompactMemStore.pdf
>
>
> Memory optimizations including compressed format representation and offheap
> allocations
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
