[
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244377#comment-15244377
]
Anastasia Braginsky commented on HBASE-14921:
---------------------------------------------
bq. How can something called CellArrayMap be an array of Cells? Whats 'Map'
doing in there? It implements Map, so be nicer to Maps in your description?
I thought CellArrayMap was something you have previously suggested… Hereby I
quote yourself:
{quote}
If so, you made CellSet (or Eshcar) made CellSet which implements NaviableSet.
Here we are slinging Cells and implement NavigableMap. Call it CellMap rather
than CellBock? I was trying to come up with a name that made reference to how
it is actually implemented – e.g. like ConcurrentSkipListMap – which would seem
to say all it CellArrayMap rather than CellBlock but when I see
CellBlockObjectArray later.. may be CellBinSearchMap….
{quote}
“CellAray” is how it is implemented and “Map” is what it is implemented… Sounds
quite reasonable for me… What name would you suggest?
\\
\\
\\
bq. And 'only using JVM'... what else? You mean 'on heap’?
Correct, meant “on heap”, fixed that
bq. We pass comparator on construction and in createSubCellFlatMap? We need it
in both places? The cell array is ordered? Why we need a comparator if it
already ordered?
The comparator is needed both in constructor and in createSubCellFlatMap,
because createSubCellFlatMap calls the constructor of the relevant derived
class. We need comparator, for binary search, although the array is ordered. We
have a cell X as input for binary search and then we need to compare X to some
cells in the array.
bq. When getCell, we should check the boundaries... the min and max.
OK, fixed that
> Memory optimizations
> --------------------
>
> Key: HBASE-14921
> URL: https://issues.apache.org/jira/browse/HBASE-14921
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Eshcar Hillel
> Assignee: Anastasia Braginsky
> Attachments: CellBlocksSegmentInMemStore.pdf,
> CellBlocksSegmentinthecontextofMemStore(1).pdf, HBASE-14921-V01.patch,
> HBASE-14921-V02.patch, HBASE-14921-V03.patch,
> IntroductiontoNewFlatandCompactMemStore.pdf
>
>
> Memory optimizations including compressed format representation and offheap
> allocations
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
