[ 
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255405#comment-15255405
 ] 

stack commented on HBASE-15693:
-------------------------------

[~Apache9] I don't see why we'd have different checkstyle on different branches 
other than by oversight. Suggest applying master checkstyle everywhere we do 
checkstyle.

> Reconsider the ImportOrder rule of checkstyle
> ---------------------------------------------
>
>                 Key: HBASE-15693
>                 URL: https://issues.apache.org/jira/browse/HBASE-15693
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>              Labels: checkstyle
>         Attachments: HBASE-15693.patch
>
>
> I have been confused many times with the wrong import order checkstyle 
> warnings in the pre commit result. And I haven't found any developer guide 
> which tells me what is the right order so this time I decided to read the 
> rule by myself.
> In the ImportOrder section, we declare sortStaticImportsAlphabetically which 
> can only work with option 'top' or 'bottom'(which means place static imports 
> on top or bottom) and use the default option which is 'under'.
> I prefer placing static import on top, so I suggest here we set option to 
> 'top'.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to