[
https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255467#comment-15255467
]
Hadoop QA commented on HBASE-15693:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
8s {color} | {color:green} 0.98 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
6s {color} | {color:green} 0.98 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s
{color} | {color:green} 0.98 passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 6s
{color} | {color:green} 0.98 passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
7s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
6s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 9m
17s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0
2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 6s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 6s
{color} | {color:green} hbase-checkstyle in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 11m 52s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12800401/HBASE-15693-0.98.patch
|
| JIRA Issue | HBASE-15693 |
| Optional Tests | asflicense javac javadoc unit xml |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | 0.98 / 9bc00b8 |
| Default Java | 1.7.0_79 |
| Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0
/usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/1571/testReport/ |
| modules | C: hbase-checkstyle U: hbase-checkstyle |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/1571/console |
| Powered by | Apache Yetus 0.2.1 http://yetus.apache.org |
This message was automatically generated.
> Reconsider the ImportOrder rule of checkstyle
> ---------------------------------------------
>
> Key: HBASE-15693
> URL: https://issues.apache.org/jira/browse/HBASE-15693
> Project: HBase
> Issue Type: Bug
> Components: build
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Labels: checkstyle
> Attachments: HBASE-15693-0.98.patch, HBASE-15693-branch-1.0.patch,
> HBASE-15693-branch-1.1.patch, HBASE-15693-branch-1.2.patch,
> HBASE-15693-branch-1.3.patch, HBASE-15693-branch-1.patch, HBASE-15693.patch
>
>
> I have been confused many times with the wrong import order checkstyle
> warnings in the pre commit result. And I haven't found any developer guide
> which tells me what is the right order so this time I decided to read the
> rule by myself.
> In the ImportOrder section, we declare sortStaticImportsAlphabetically which
> can only work with option 'top' or 'bottom'(which means place static imports
> on top or bottom) and use the default option which is 'under'.
> I prefer placing static import on top, so I suggest here we set option to
> 'top'.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
