[ 
https://issues.apache.org/jira/browse/HBASE-15737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266928#comment-15266928
 ] 

Ted Yu commented on HBASE-15737:
--------------------------------

Stopwatch#elapsedMillis() isn't part of guava past v16.
This method is used by all the 3 classes touched by the patch.

Replacing Guava Stopwatch with hadoop common's StopWatch would reduce the 
chance of incompatibilities in case newer version of Guava is involved.

bq. Is the issue that it's annotated Beta?

See the comment above. Guava doesn't provide good backward compatibility.

> Remove use of Guava Stopwatch
> -----------------------------
>
>                 Key: HBASE-15737
>                 URL: https://issues.apache.org/jira/browse/HBASE-15737
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 15737.v1.txt
>
>
> HBASE-14963 removed reference to Guava Stopwatch from hbase-client module.
> However, there're still 3 classes referring to Guava Stopwatch :
> hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java:import
>  com.google.common.base.Stopwatch;
> hbase-server/src/main/java/org/apache/hadoop/hbase/util/JvmPauseMonitor.java:import
>  com.google.common.base.Stopwatch;
> hbase-server/src/test/java/org/apache/hadoop/hbase/ScanPerformanceEvaluation.java:import
>  com.google.common.base.Stopwatch;
> We should remove reference to Guava Stopwatch.
> hadoop is no longer referencing Guava Stopwatch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to