[ 
https://issues.apache.org/jira/browse/HBASE-15737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267087#comment-15267087
 ] 

Sean Busbey commented on HBASE-15737:
-------------------------------------

{quote}
bq. either use TimeUnit
I cannot - commons StopWatch doesn't provide such capability.
Adding comment in the next patch.
{quote}

? You could use TimeUnit directly. There's no need for the underlying library 
to do it, since you as the dev know that you're getting a long that is millis. 
i.e. {{TimeUnit.MILLISECONDS.toSeconds(elapsedTime)}}

> Remove use of Guava Stopwatch
> -----------------------------
>
>                 Key: HBASE-15737
>                 URL: https://issues.apache.org/jira/browse/HBASE-15737
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 15737.v1.txt
>
>
> HBASE-14963 removed reference to Guava Stopwatch from hbase-client module.
> However, there're still 3 classes referring to Guava Stopwatch :
> hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java:import
>  com.google.common.base.Stopwatch;
> hbase-server/src/main/java/org/apache/hadoop/hbase/util/JvmPauseMonitor.java:import
>  com.google.common.base.Stopwatch;
> hbase-server/src/test/java/org/apache/hadoop/hbase/ScanPerformanceEvaluation.java:import
>  com.google.common.base.Stopwatch;
> We should remove reference to Guava Stopwatch.
> hadoop is no longer referencing Guava Stopwatch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to