[ https://issues.apache.org/jira/browse/HBASE-15889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302440#comment-15302440 ]
Hadoop QA commented on HBASE-15889: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 13 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 17s {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 12s {color} | {color:green} master passed {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 6s {color} | {color:red} buildstats in master failed with JDK v1.8.0. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 5s {color} | {color:red} buildstats in master failed with JDK v1.7.0_79. {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 25s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 47s {color} | {color:green} master passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 13s {color} | {color:red} branch/hbase-it no findbugs output file (hbase-it/target/findbugsXml.xml) {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 40s {color} | {color:red} hbase-rest in master has 2 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 6s {color} | {color:red} buildstats in master failed. {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 6s {color} | {color:red} buildstats in master failed with JDK v1.8.0. {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 4s {color} | {color:red} buildstats in master failed with JDK v1.7.0_79. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 4s {color} | {color:red} buildstats in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 4s {color} | {color:red} buildstats in the patch failed with JDK v1.8.0. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 4s {color} | {color:red} buildstats in the patch failed with JDK v1.8.0. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 5s {color} | {color:red} buildstats in the patch failed with JDK v1.7.0_79. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 5s {color} | {color:red} buildstats in the patch failed with JDK v1.7.0_79. {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 24s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 41s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 9m 7s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.0. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 17s {color} | {color:red} patch/hbase-it no findbugs output file (hbase-it/target/findbugsXml.xml) {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 5s {color} | {color:red} buildstats in the patch failed. {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 8s {color} | {color:red} buildstats in the patch failed with JDK v1.8.0. {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 5s {color} | {color:red} buildstats in the patch failed with JDK v1.7.0_79. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 8s {color} | {color:green} hbase-annotations in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 42s {color} | {color:green} hbase-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 54s {color} | {color:green} hbase-client in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 21s {color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 101m 9s {color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 31s {color} | {color:green} hbase-thrift in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 21s {color} | {color:green} hbase-it in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 46s {color} | {color:green} hbase-rest in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 9s {color} | {color:red} buildstats in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 46s {color} | {color:green} Patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 174m 25s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12806204/HBASE-15889-v1.patch | | JIRA Issue | HBASE-15889 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/test_framework/yetus-0.2.1/lib/precommit/personality/hbase.sh | | git revision | master / 94696d4 | | Default Java | 1.7.0_79 | | Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 | | compile | https://builds.apache.org/job/PreCommit-HBASE-Build/2017/artifact/patchprocess/branch-compile-dev-support_jenkins-tools_buildstats-jdk1.8.0.txt | | compile | https://builds.apache.org/job/PreCommit-HBASE-Build/2017/artifact/patchprocess/branch-compile-dev-support_jenkins-tools_buildstats-jdk1.7.0_79.txt | | findbugs | v3.0.0 | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/2017/artifact/patchprocess/branch-findbugs-hbase-rest-warnings.html | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/2017/artifact/patchprocess/branch-findbugs-dev-support_jenkins-tools_buildstats.txt | | javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/2017/artifact/patchprocess/branch-javadoc-dev-support_jenkins-tools_buildstats-jdk1.8.0.txt | | javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/2017/artifact/patchprocess/branch-javadoc-dev-support_jenkins-tools_buildstats-jdk1.7.0_79.txt | | mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/2017/artifact/patchprocess/patch-mvninstall-dev-support_jenkins-tools_buildstats.txt | | compile | https://builds.apache.org/job/PreCommit-HBASE-Build/2017/artifact/patchprocess/patch-compile-dev-support_jenkins-tools_buildstats-jdk1.8.0.txt | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/2017/artifact/patchprocess/patch-compile-dev-support_jenkins-tools_buildstats-jdk1.8.0.txt | | compile | https://builds.apache.org/job/PreCommit-HBASE-Build/2017/artifact/patchprocess/patch-compile-dev-support_jenkins-tools_buildstats-jdk1.7.0_79.txt | | javac | https://builds.apache.org/job/PreCommit-HBASE-Build/2017/artifact/patchprocess/patch-compile-dev-support_jenkins-tools_buildstats-jdk1.7.0_79.txt | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/2017/artifact/patchprocess/patch-findbugs-dev-support_jenkins-tools_buildstats.txt | | javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/2017/artifact/patchprocess/patch-javadoc-dev-support_jenkins-tools_buildstats-jdk1.8.0.txt | | javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/2017/artifact/patchprocess/patch-javadoc-dev-support_jenkins-tools_buildstats-jdk1.7.0_79.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/2017/artifact/patchprocess/patch-unit-dev-support_jenkins-tools_buildstats.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/2017/testReport/ | | modules | C: hbase-annotations hbase-common hbase-client hbase-hadoop2-compat hbase-server hbase-thrift hbase-it hbase-rest dev-support/jenkins-tools/buildstats U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/2017/console | | Powered by | Apache Yetus 0.2.1 http://yetus.apache.org | This message was automatically generated. > String case conversions are locale-sensitive, used without locale > ----------------------------------------------------------------- > > Key: HBASE-15889 > URL: https://issues.apache.org/jira/browse/HBASE-15889 > Project: HBase > Issue Type: Bug > Affects Versions: 1.2.0 > Reporter: Sean Mackrory > Assignee: Sean Mackrory > Priority: Minor > Attachments: HBASE-15889-v1.patch > > > Static code analysis is flagging cases of String.toLowerCase and > String.toUpperCase being used without Locale. From the API reference: > {quote} > Note: This method is locale sensitive, and may produce unexpected results if > used for strings that are intended to be interpreted locale independently. > Examples are programming language identifiers, protocol keys, and HTML tags. > For instance, "TITLE".toLowerCase() in a Turkish locale returns "t\u0131tle", > where '\u0131' is the LATIN SMALL LETTER DOTLESS I character. To obtain > correct results for locale insensitive strings, use toLowerCase(Locale.ROOT). > {quote} > Many uses of these functions do appear to be looking up classes, etc. and not > dealing with stored data, so I'd think there aren't significant compatibility > problems here and specifying the locale is indeed the safer way to go. -- This message was sent by Atlassian JIRA (v6.3.4#6332)