[ https://issues.apache.org/jira/browse/HBASE-15889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305004#comment-15305004 ]
Sean Busbey commented on HBASE-15889: ------------------------------------- Would you mind updating your patch now that we've removed the jenkins-tools module? > String case conversions are locale-sensitive, used without locale > ----------------------------------------------------------------- > > Key: HBASE-15889 > URL: https://issues.apache.org/jira/browse/HBASE-15889 > Project: HBase > Issue Type: Bug > Affects Versions: 1.2.0 > Reporter: Sean Mackrory > Assignee: Sean Mackrory > Priority: Minor > Attachments: HBASE-15889-v1.patch > > > Static code analysis is flagging cases of String.toLowerCase and > String.toUpperCase being used without Locale. From the API reference: > {quote} > Note: This method is locale sensitive, and may produce unexpected results if > used for strings that are intended to be interpreted locale independently. > Examples are programming language identifiers, protocol keys, and HTML tags. > For instance, "TITLE".toLowerCase() in a Turkish locale returns "t\u0131tle", > where '\u0131' is the LATIN SMALL LETTER DOTLESS I character. To obtain > correct results for locale insensitive strings, use toLowerCase(Locale.ROOT). > {quote} > Many uses of these functions do appear to be looking up classes, etc. and not > dealing with stored data, so I'd think there aren't significant compatibility > problems here and specifying the locale is indeed the safer way to go. -- This message was sent by Atlassian JIRA (v6.3.4#6332)