[
https://issues.apache.org/jira/browse/HBASE-4820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154342#comment-13154342
]
jirapos...@reviews.apache.org commented on HBASE-4820:
------------------------------------------------------
bq. On 2011-11-21 03:29:17, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java, line
271
bq. > <https://reviews.apache.org/r/2895/diff/1/?file=59537#file59537line271>
bq. >
bq. > handleDeadWorkers would be a better method name.
Yes, that's right.
bq. On 2011-11-21 03:29:17, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java, line
431
bq. > <https://reviews.apache.org/r/2895/diff/1/?file=59538#file59538line431>
bq. >
bq. > retry_count is the remaining count. This log message should be
clearer.
That's right
bq. On 2011-11-21 03:29:17, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java, line
480
bq. > <https://reviews.apache.org/r/2895/diff/1/?file=59538#file59538line480>
bq. >
bq. > We should say 'remaining retries='
Fixed.
bq. On 2011-11-21 03:29:17, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java, line
453
bq. > <https://reviews.apache.org/r/2895/diff/1/?file=59538#file59538line453>
bq. >
bq. > Can we implement this item now ?
We can do it in another jira.
bq. On 2011-11-21 03:29:17, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java, line
671
bq. > <https://reviews.apache.org/r/2895/diff/1/?file=59538#file59538line671>
bq. >
bq. > Please adjust indentation.
That's right.
bq. On 2011-11-21 03:29:17, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java, line
210
bq. > <https://reviews.apache.org/r/2895/diff/1/?file=59538#file59538line210>
bq. >
bq. > Please remove white space.
I assume you suggest we should not use tab. Please correct me if I am wrong.
bq. On 2011-11-21 03:29:17, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java, line
952
bq. > <https://reviews.apache.org/r/2895/diff/1/?file=59538#file59538line952>
bq. >
bq. > Please adjust indentation for these 4 lines.
Fixed. Replaced tabs with spaces.
bq. On 2011-11-21 03:29:17, Ted Yu wrote:
bq. > src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java, line
965
bq. > <https://reviews.apache.org/r/2895/diff/1/?file=59538#file59538line965>
bq. >
bq. > Should read 'splitlog workers'
fixed.
bq. On 2011-11-21 03:29:17, Ted Yu wrote:
bq. >
src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java, line
648
bq. > <https://reviews.apache.org/r/2895/diff/1/?file=59540#file59540line648>
bq. >
bq. > Adjust indentation, please.
fixed.
- Jimmy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2895/#review3385
-----------------------------------------------------------
On 2011-11-21 02:06:29, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2895/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-21 02:06:29)
bq.
bq.
bq. Review request for hbase, Todd Lipcon and Jonathan Robie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Distributed log splitting coding enhancement to make it easier to
understand, no semantics change.
bq. It is some issue raised during the code review in back porting this
feature to CDH.
bq.
bq.
bq. This addresses bug HBASE-4820.
bq. https://issues.apache.org/jira/browse/HBASE-4820
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
f7ef653
bq. src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
b9a3a2c
bq. src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
7dd67e9
bq. src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java
1d329b0
bq. src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
21747b1
bq.
src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
51daa1f
bq. src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java
c8684ec
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitLogWorker.java
84d76e8
bq.
bq. Diff: https://reviews.apache.org/r/2895/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran unit tests. Non-flaky tests are green. Two client tests didn't pass,
which are not related to this change.
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> Distributed log splitting coding enhancement to make it easier to understand,
> no semantics change
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-4820
> URL: https://issues.apache.org/jira/browse/HBASE-4820
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Affects Versions: 0.94.0
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Labels: newbie
> Fix For: 0.94.0
>
> Attachments:
> 0001-HBASE-4820-Distributed-log-splitting-coding-enhancement-to-make----it-easier-to-understand,-no-semantics-change..patch,
>
> 0001-HBASE-4820-Distributed-log-splitting-coding-enhancement-to-make----it-easier-to-understand,-no-semantics-change..patch
>
>
> In reviewing distributed log splitting feature, we found some cosmetic
> issues. They make the code hard to understand.
> It will be great to fix them. For this issue, there should be no semantic
> change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
