[
https://issues.apache.org/jira/browse/HBASE-4820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154340#comment-13154340
]
jirapos...@reviews.apache.org commented on HBASE-4820:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2895/
-----------------------------------------------------------
(Updated 2011-11-21 18:22:03.402105)
Review request for hbase, Todd Lipcon and Jonathan Robie.
Changes
-------
Updated patch diff after changes per review.
Summary
-------
Distributed log splitting coding enhancement to make it easier to understand,
no semantics change.
It is some issue raised during the code review in back porting this feature to
CDH.
This addresses bug HBASE-4820.
https://issues.apache.org/jira/browse/HBASE-4820
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java f7ef653
src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java b9a3a2c
src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java 7dd67e9
src/main/java/org/apache/hadoop/hbase/regionserver/SplitLogWorker.java
1d329b0
src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
21747b1
src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
51daa1f
src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java c8684ec
src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitLogWorker.java
84d76e8
Diff: https://reviews.apache.org/r/2895/diff
Testing
-------
Ran unit tests. Non-flaky tests are green. Two client tests didn't pass, which
are not related to this change.
Thanks,
Jimmy
> Distributed log splitting coding enhancement to make it easier to understand,
> no semantics change
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-4820
> URL: https://issues.apache.org/jira/browse/HBASE-4820
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Affects Versions: 0.94.0
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Labels: newbie
> Fix For: 0.94.0
>
> Attachments:
> 0001-HBASE-4820-Distributed-log-splitting-coding-enhancement-to-make----it-easier-to-understand,-no-semantics-change..patch,
>
> 0001-HBASE-4820-Distributed-log-splitting-coding-enhancement-to-make----it-easier-to-understand,-no-semantics-change..patch
>
>
> In reviewing distributed log splitting feature, we found some cosmetic
> issues. They make the code hard to understand.
> It will be great to fix them. For this issue, there should be no semantic
> change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
