[ https://issues.apache.org/jira/browse/HBASE-15965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Appy updated HBASE-15965: ------------------------- Attachment: HBASE-15965.master.003.patch > Shell test changes. Use @shell.command instead directly calling functions in > admin.rb and other libraries. > ---------------------------------------------------------------------------------------------------------- > > Key: HBASE-15965 > URL: https://issues.apache.org/jira/browse/HBASE-15965 > Project: HBase > Issue Type: Bug > Reporter: Appy > Assignee: Appy > Attachments: HBASE-15965.master.001.patch, > HBASE-15965.master.002.patch, HBASE-15965.master.003.patch > > > - Changes tests to use @shell.command(:<command>, args) instead of > directly using functions in admin.rb, etc. > - Testing by executing a command will cover the exact path users will > trigger, so its better testing compared to just testing library functions. > - Uncovered bug in major_compact.rb with this approach. It was calling > admin.majorCompact() which doesn't exist but our tests didn't catch it since > they directly tested admin.major_compact() -- This message was sent by Atlassian JIRA (v6.3.4#6332)