[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159607#comment-13159607 ]
jirapos...@reviews.apache.org commented on HBASE-4382: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2963/ ----------------------------------------------------------- Review request for hbase. Summary ------- Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name. This addresses bug hbase-4382. https://issues.apache.org/jira/browse/hbase-4382 Diffs ----- src/main/java/org/apache/hadoop/hbase/HConstants.java d22f50a src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 0c1fa3f src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 1c49dc5 src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java e5e60a8 src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java aa8512b src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 6af1f82 src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 4135e55 src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java 08b7de3 src/main/java/org/apache/hadoop/hbase/rest/RegionsResource.java bf85bc1 src/main/java/org/apache/hadoop/hbase/rest/model/TableRegionModel.java 67e7a04 src/main/resources/hbase-default.xml 7059c60 src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 66d808f src/test/java/org/apache/hadoop/hbase/TestKeyValue.java 7af4db4 src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 940d726 src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java b579b29 src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosestAtOrBefore.java 49bfc5a src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java 477e772 src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java 24903f3 src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java 4a8bb69 src/test/java/org/apache/hadoop/hbase/rest/model/TestTableRegionModel.java 60e0e41 src/test/ruby/hbase/admin_test.rb 0c2672b Diff: https://reviews.apache.org/r/2963/diff Testing ------- Thanks, Alex > Region encoded name is hash of tablename + start key + regionid (timestamp); > should include end key when hashing. > ----------------------------------------------------------------------------------------------------------------- > > Key: HBASE-4382 > URL: https://issues.apache.org/jira/browse/HBASE-4382 > Project: HBase > Issue Type: Sub-task > Reporter: stack > Assignee: Alex Newman > Labels: noob > > Seems odd that region encoded name is same for regions if made in same second > with same start key tough their end keys are different. It can happen in > unit test. Should mix in the end key when coming up w/ the region name > encoded name. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira