[ https://issues.apache.org/jira/browse/HBASE-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159876#comment-13159876 ]
jirapos...@reviews.apache.org commented on HBASE-4382: ------------------------------------------------------ bq. On 2011-11-30 06:52:58, Prakash Khemani wrote: bq. > Is this change backward compatible? bq. > bq. > I didn't quite get the motivation for the change. If there are tests that create overlapping regions (i.e. regions w/ same start key) then aren't those tests at fault? One side note, this review was discarded as I posted all of this stuff in a confusing manner on my first try. In the future, it might more sense to comment on the jira. On the first question, no it isn't and we will need a migration script as a part of 4616. On the second, I agree about the tests part, if that's what was meant in the jira. On the other hand, wouldn't it be nice if we could uniquely identify meta/root key entries after a split? It just feels right to me. The nice part about it being a hash is that this doesn't create storage overhead. I could check for performance issues if that's what your worried about. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2963/#review3575 ----------------------------------------------------------- On 2011-11-29 22:52:32, Alex Newman wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/2963/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-11-29 22:52:32) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. ------- bq. bq. Seems odd that region encoded name is same for regions if made in same second with same start key tough their end keys are different. It can happen in unit test. Should mix in the end key when coming up w/ the region name encoded name. bq. bq. bq. This addresses bug hbase-4382. bq. https://issues.apache.org/jira/browse/hbase-4382 bq. bq. bq. Diffs bq. ----- bq. bq. src/main/java/org/apache/hadoop/hbase/HConstants.java d22f50a bq. src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 0c1fa3f bq. src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 1c49dc5 bq. src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java e5e60a8 bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java aa8512b bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 6af1f82 bq. src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 4135e55 bq. src/main/java/org/apache/hadoop/hbase/client/MetaSearchRow.java PRE-CREATION bq. src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java 08b7de3 bq. src/main/java/org/apache/hadoop/hbase/rest/RegionsResource.java bf85bc1 bq. src/main/java/org/apache/hadoop/hbase/rest/model/TableRegionModel.java 67e7a04 bq. src/main/resources/hbase-default.xml 7059c60 bq. src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 66d808f bq. src/test/java/org/apache/hadoop/hbase/TestKeyValue.java 7af4db4 bq. src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 940d726 bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java b579b29 bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosestAtOrBefore.java 49bfc5a bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java 477e772 bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java 24903f3 bq. src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java 4a8bb69 bq. src/test/java/org/apache/hadoop/hbase/rest/model/TestTableRegionModel.java 60e0e41 bq. src/test/ruby/hbase/admin_test.rb 0c2672b bq. bq. Diff: https://reviews.apache.org/r/2963/diff bq. bq. bq. Testing bq. ------- bq. bq. bq. Thanks, bq. bq. Alex bq. bq. > Region encoded name is hash of tablename + start key + regionid (timestamp); > should include end key when hashing. > ----------------------------------------------------------------------------------------------------------------- > > Key: HBASE-4382 > URL: https://issues.apache.org/jira/browse/HBASE-4382 > Project: HBase > Issue Type: Sub-task > Reporter: stack > Assignee: Alex Newman > Labels: noob > > Seems odd that region encoded name is same for regions if made in same second > with same start key tough their end keys are different. It can happen in > unit test. Should mix in the end key when coming up w/ the region name > encoded name. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira