[
https://issues.apache.org/jira/browse/HBASE-4927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162997#comment-13162997
]
[email protected] commented on HBASE-4927:
------------------------------------------------------
bq. On 2011-12-03 22:11:00, Ted Yu wrote:
bq. > src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java,
line 364
bq. > <https://reviews.apache.org/r/2992/diff/1/?file=61616#file61616line364>
bq. >
bq. > This sentence seems to be inconsistent with the comment on line 361.
This should be the first parent in the test scenario. But it is the last
region. Let me make the document clear.
bq. On 2011-12-03 22:11:00, Ted Yu wrote:
bq. > src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java,
line 344
bq. > <https://reviews.apache.org/r/2992/diff/1/?file=61616#file61616line344>
bq. >
bq. > Would parentWithSpecifiedEndKeyCleanedEvenIfDaughterGoneFirst be a
better name for this method ?
Sounds good. Let me change it.
- Jimmy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2992/#review3607
-----------------------------------------------------------
On 2011-12-02 19:09:19, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2992/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-02 19:09:19)
bq.
bq.
bq. Review request for hbase and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Some HRegionInfo related comparator doesn't consider empty end key.
That's why there are some hacks in HRegionInfo's containsRange and containsRow
method to check empty key.
bq. However, due to this issue, SplitParentFirstComparator has a bug.
bq.
bq.
bq. This addresses bug HBASE-4927.
bq. https://issues.apache.org/jira/browse/HBASE-4927
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 2a24d0b
bq. src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java b356b22
bq. src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
e047e30
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
baca241
bq.
bq. Diff: https://reviews.apache.org/r/2992/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestHRegionInfo and TestCatalogJanitor are geen.
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> CatalogJanior:SplitParentFirstComparator doesn't sort as expected, for the
> last region when the endkey is empty
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4927
> URL: https://issues.apache.org/jira/browse/HBASE-4927
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments:
> 0001-HBASE-4927-CatalogJanior-SplitParentFirstComparator-.patch
>
>
> When reviewing HBASE-4238 backporting, Jon found this issue.
> What happens if the split points are (empty end key is the last key, empty
> start key is the first key)
> Parent [A,)
> L daughter [A,B),
> R daughter [B,)
> When sorted, we gets to end key comparision which results in this incorrector
> order:
> [A,B), [A,), [B,)
> we wanted:
> [A,), [A,B), [B,)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
