[
https://issues.apache.org/jira/browse/HBASE-4927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163730#comment-13163730
]
jirapos...@reviews.apache.org commented on HBASE-4927:
------------------------------------------------------
bq. On 2011-12-05 20:28:55, Todd Lipcon wrote:
bq. > src/main/java/org/apache/hadoop/hbase/HRegionInfo.java, line 779
bq. > <https://reviews.apache.org/r/2992/diff/2/?file=61961#file61961line779>
bq. >
bq. > hard tabs
hard tabs are replaced with spaces in the v2 patch.
- Jimmy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2992/#review3634
-----------------------------------------------------------
On 2011-12-05 20:10:53, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2992/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-05 20:10:53)
bq.
bq.
bq. Review request for hbase and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Some HRegionInfo related comparator doesn't consider empty end key.
That's why there are some hacks in HRegionInfo's containsRange and containsRow
method to check empty key.
bq. However, due to this issue, SplitParentFirstComparator has a bug.
bq.
bq.
bq. This addresses bug HBASE-4927.
bq. https://issues.apache.org/jira/browse/HBASE-4927
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 2a24d0b
bq. src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java b356b22
bq. src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
e047e30
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
baca241
bq.
bq. Diff: https://reviews.apache.org/r/2992/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestHRegionInfo and TestCatalogJanitor are geen.
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> CatalogJanior:SplitParentFirstComparator doesn't sort as expected, for the
> last region when the endkey is empty
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-4927
> URL: https://issues.apache.org/jira/browse/HBASE-4927
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments:
> 0001-HBASE-4927-CatalogJanior-SplitParentFirstComparator-.patch,
> 0001-HBASE-4927-CatalogJanior-SplitParentFirstComparator_v2.patch
>
>
> When reviewing HBASE-4238 backporting, Jon found this issue.
> What happens if the split points are (empty end key is the last key, empty
> start key is the first key)
> Parent [A,)
> L daughter [A,B),
> R daughter [B,)
> When sorted, we gets to end key comparision which results in this incorrector
> order:
> [A,B), [A,), [B,)
> we wanted:
> [A,), [A,B), [B,)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
