[ https://issues.apache.org/jira/browse/HBASE-4927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163785#comment-13163785 ]
Hadoop QA commented on HBASE-4927: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12506287/hbase-4927-fix-ws.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -160 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 71 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/454//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/454//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/454//console This message is automatically generated. > CatalogJanior:SplitParentFirstComparator doesn't sort as expected, for the > last region when the endkey is empty > --------------------------------------------------------------------------------------------------------------- > > Key: HBASE-4927 > URL: https://issues.apache.org/jira/browse/HBASE-4927 > Project: HBase > Issue Type: Bug > Components: master > Affects Versions: 0.92.0, 0.94.0 > Reporter: Jimmy Xiang > Assignee: Jimmy Xiang > Priority: Minor > Fix For: 0.94.0 > > Attachments: > 0001-HBASE-4927-CatalogJanior-SplitParentFirstComparator-.patch, > 0001-HBASE-4927-CatalogJanior-SplitParentFirstComparator_v2.patch, > hbase-4927-fix-ws.txt > > > When reviewing HBASE-4238 backporting, Jon found this issue. > What happens if the split points are (empty end key is the last key, empty > start key is the first key) > Parent [A,) > L daughter [A,B), > R daughter [B,) > When sorted, we gets to end key comparision which results in this incorrector > order: > [A,B), [A,), [B,) > we wanted: > [A,), [A,B), [B,) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira