[
https://issues.apache.org/jira/browse/HBASE-16835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15610882#comment-15610882
]
stack commented on HBASE-16835:
-------------------------------
bq. But I do not think the precommit job could read our document and change the
default protoc when building HBase...
We don't do protoc as part of our build. It is a step done outside of build to
generate src that is checked in for use by build.
bq. Is it possible to make use of protobuf-maven-plugin when building
hbase-protocol-shaded?
Thanks for the pointer. It is better than the plugin we were using. Let me use
it everywhere w/ clear instruction that it will take care of using right protoc
in hbase-protocol-shaded but everywhere else you need to supply the pb2.5.0
since it cant. It is better in that I do not have to list the .protos in two
places, in the dir and in the pom.
On the patch, aren't you polluting ClusterRegistry interface when you add those
new methods that don't seem to have anything to do w/ Cluster ("Should only be
called once."... then closed)? Do another Interface for your new stuff?
Otherwise patch looks good to me. Trying to see if it could be incompat with an
older client writing zk but not seeing it.
> Revisit the zookeeper usage at client side
> ------------------------------------------
>
> Key: HBASE-16835
> URL: https://issues.apache.org/jira/browse/HBASE-16835
> Project: HBase
> Issue Type: Sub-task
> Components: Client, Zookeeper
> Affects Versions: 2.0.0
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-16835.patch
>
>
> Watcher or not.
> Curator or not.
> Keep connection or not.
> ...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
