[ 
https://issues.apache.org/jira/browse/HBASE-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15694660#comment-15694660
 ] 

Jerry He commented on HBASE-17174:
----------------------------------

BufferedMutator should not close an external ExecutorService pool.
Patch looks good.
Besides this fix, the other changes are mostly refactoring/cleanup?
Can you upload patch to RB just to be careful?

> Use shared threadpool in BufferedMutatorImpl
> --------------------------------------------
>
>                 Key: HBASE-17174
>                 URL: https://issues.apache.org/jira/browse/HBASE-17174
>             Project: HBase
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: ChiaPing Tsai
>            Assignee: ChiaPing Tsai
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17174.v0.patch, HBASE-17174.v1.patch, 
> HBASE-17174.v2.patch
>
>
> A update-heavy application, for example, loader, creates many BufferedMutator 
> for batch updates. But these BufferedMutators can’t share a large threadpool 
> because the shutdown() method will be called when closing any 
> BufferedMutator. This patch adds a flag into BufferedMutatorParams for 
> preventing calling the shutdown() method in BufferedMutatorImpl#close



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to