[ https://issues.apache.org/jira/browse/HBASE-5053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171153#comment-13171153 ]
nkeywal commented on HBASE-5053: -------------------------------- v2 with Ted's comment taken into account (including error log level) and added a toString method on connection HConnectionKey. Tested locally on TestHCM. > HCM Tests leaks connections > --------------------------- > > Key: HBASE-5053 > URL: https://issues.apache.org/jira/browse/HBASE-5053 > Project: HBase > Issue Type: Bug > Components: test > Affects Versions: 0.94.0 > Reporter: nkeywal > Assignee: nkeywal > Priority: Minor > Attachments: 5053.patch, 5053.v2.patch > > > There are simple leaks and one more complex. > The complex one comes from the fact fact > HConnectionManager.HConnectionImplementation keeps a *reference* to the > configuration used for the creation. So if this configuration is updated > later, the HConnectionKey created initially will differ from the current one. > As a consequence, the close() will not find the connection anymore in the > list, and the connection won't be deleted. > I added a warning when a close does not find the connection in the list; but > I wonder if we should not copy the HConnectionKey instead of keeping a > reference. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira