[ https://issues.apache.org/jira/browse/HBASE-5053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171223#comment-13171223 ]
Hadoop QA commented on HBASE-5053: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12507715/5053.v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -152 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 76 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.client.TestInstantSchemaChange org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/525//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/525//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/525//console This message is automatically generated. > HCM Tests leaks connections > --------------------------- > > Key: HBASE-5053 > URL: https://issues.apache.org/jira/browse/HBASE-5053 > Project: HBase > Issue Type: Bug > Components: test > Affects Versions: 0.94.0 > Reporter: nkeywal > Assignee: nkeywal > Priority: Minor > Attachments: 5053.patch, 5053.v2.patch > > > There are simple leaks and one more complex. > The complex one comes from the fact fact > HConnectionManager.HConnectionImplementation keeps a *reference* to the > configuration used for the creation. So if this configuration is updated > later, the HConnectionKey created initially will differ from the current one. > As a consequence, the close() will not find the connection anymore in the > list, and the connection won't be deleted. > I added a warning when a close does not find the connection in the list; but > I wonder if we should not copy the HConnectionKey instead of keeping a > reference. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira