[ 
https://issues.apache.org/jira/browse/HBASE-17680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881670#comment-15881670
 ] 

Enis Soztutar commented on HBASE-17680:
---------------------------------------

Couple of more comments: 
 - At least some of the methods are C-style, and rest are C++ style. We can 
just stick with C++ and encapsulate everything inside the class. 
 - Also, you can use much nicer ifstream instead of fopen / flose, and use 
std::string instead of mallocing c-strings. You can use {{string::c_str()}} to 
pass back to the JVM args. 
 - Instead of {{(*env).Foo()}}, you should use {{env->Foo()}}. 


> Run mini cluster through JNI in tests
> -------------------------------------
>
>                 Key: HBASE-17680
>                 URL: https://issues.apache.org/jira/browse/HBASE-17680
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 17680.v1.txt, 17680.v3.txt, 17680.v8.txt
>
>
> Currently tests start local hbase cluster through hbase shell.
> There is less control over the configuration of the local cluster this way.
> This issue would replace hbase shell with JNI interface to mini cluster.
> We would have full control over the cluster behavior.
> Thanks to [~devaraj] who started this initiative.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to