[
https://issues.apache.org/jira/browse/HBASE-5150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182350#comment-13182350
]
jirapos...@reviews.apache.org commented on HBASE-5150:
------------------------------------------------------
bq. On 2012-01-09 01:56:13, Ted Yu wrote:
bq. >
src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java,
line 302
bq. > <https://reviews.apache.org/r/3433/diff/1/?file=67167#file67167line302>
bq. >
bq. > Should this read ', or until it is ...' ?
It will keep waiting until it is interrupted. The task won't be removed from
the task map in this test case actually because slm.ignoreZKDeleteForTesting is
set to true.
I will add this to the doc.
bq. On 2012-01-09 01:56:13, Ted Yu wrote:
bq. >
src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java,
line 322
bq. > <https://reviews.apache.org/r/3433/diff/1/?file=67167#file67167line322>
bq. >
bq. > Typo: exception
right.
bq. On 2012-01-09 01:56:13, Ted Yu wrote:
bq. > src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java,
line 481
bq. > <https://reviews.apache.org/r/3433/diff/1/?file=67168#file67168line481>
bq. >
bq. > So this is no longer a failure case ?
It doesn't fail here. It tests a scenario when a znode is removed by others.
- Jimmy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3433/#review4256
-----------------------------------------------------------
On 2012-01-09 01:32:36, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3433/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-09 01:32:36)
bq.
bq.
bq. Review request for hbase, Todd Lipcon and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Cleaned up the tests introduced in HBASE-5081, added some documentation.
bq.
bq.
bq. This addresses bug HBASE-5150.
bq. https://issues.apache.org/jira/browse/HBASE-5150
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
0ef0e33
bq.
src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
b0487f1
bq. src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java
0974b56
bq.
bq. Diff: https://reviews.apache.org/r/3433/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Affected tests: TestDistributedLogSplitting and TestSplitLogManager, are
passed
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> Fail in a thread may not fail a test, clean up log splitting test
> -----------------------------------------------------------------
>
> Key: HBASE-5150
> URL: https://issues.apache.org/jira/browse/HBASE-5150
> Project: HBase
> Issue Type: Test
> Affects Versions: 0.94.0
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Minor
> Attachments: hbase-5150.txt
>
>
> This is to clean up some tests for HBASE-5081. The Assert.fail method in a
> separate thread will terminate the thread, but may not fail the test.
> We can use callable, so that we can get the error in getting the result.
> Some documentation to explain the test will be helpful too.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
