[ 
https://issues.apache.org/jira/browse/HBASE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185244#comment-13185244
 ] 

Jean-Daniel Cryans commented on HBASE-4224:
-------------------------------------------

Not a fan of the patch, the first problem I see is that flushing a list of 
regions and keeping the handler open will trigger socket exceptions too easily 
when you have more than a handful of regions. Also it adds a lot of code.

Unfortunately I don't have a better option in mind and the original problem 
seems sketchy to me. There's no easy way to tell when all flushes are done (as 
shown by the acrobatics of the latest patch) and currently flushes are done in 
sync with the client call. At this point I'm of the opinion that we should just:

 - add an async call to flush (that does what compact currently does).
 - add the functionality in HBA to request the flushing of all regions on one 
region server. It would call the RS x times and those calls would be quick 
since it just queues the flush request.

You can then ask for the flush queue size through JMX (and I'm sure there are 
other means) so that when you are close to one you call for the log roll. This 
last step could also be manual or scripted.
                
> Need a flush by regionserver rather than by table option
> --------------------------------------------------------
>
>                 Key: HBASE-4224
>                 URL: https://issues.apache.org/jira/browse/HBASE-4224
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>            Reporter: stack
>            Assignee: Akash Ashok
>         Attachments: HBase-4224-v2.patch, HBase-4224.patch
>
>
> This evening needed to clean out logs on the cluster.  logs are by 
> regionserver.  to let go of logs, we need to have all edits emptied from 
> memory.  only flush is by table or region.  We need to be able to flush the 
> regionserver.  Need to add this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to