[ 
https://issues.apache.org/jira/browse/HBASE-18444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151249#comment-16151249
 ] 

Ted Yu commented on HBASE-18444:
--------------------------------

{code}
539         if(isValidMetaTableSuffix(metaTableSuffix)) {
540           metaTableName = DEFAULT_META_TABLE_NAME_STR + "_" + 
metaTableSuffix;
{code}
isValidMetaTableSuffix() gives the impression that metaTableSuffix should be 
the whole suffix.
But line 540 adds underscore.
Suggest consolidating with variable holding the whole suffix.

Please attach patch for master branch.

> Add support for specifying custom meta table suffix
> ---------------------------------------------------
>
>                 Key: HBASE-18444
>                 URL: https://issues.apache.org/jira/browse/HBASE-18444
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0, 1.3.1
>            Reporter: Ajay Jadhav
>            Assignee: Ajay Jadhav
>            Priority: Minor
>              Labels: patch
>             Fix For: 1.4.0
>
>         Attachments: HBASE-18444.branch-1.001.patch
>
>
> This patch provides user an ability to have a custom meta table suffix.
> In order to share a common rootDir amongst multiple HBase clusters, we need 
> separate meta table for each cluster.
> With custom meta table suffix, the meta table is named in the form of 
> meta_{suffix} making it specific to a cluster.
> Users can specify the meta table suffix as part of hbase-site.xml.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to