[ 
https://issues.apache.org/jira/browse/HBASE-18444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155780#comment-16155780
 ] 

stack commented on HBASE-18444:
-------------------------------

[~ted_yu]

bq. other committers please consider this blocked on the umbrella.

Quote is from above. Is the umbrella 'done'?

Looking at the patch [~ajayjadhav] It seems odd that inside TableName 
getMetaTableName is public as is isValidMetaTableSuffix especially when 
META_TABLE_NAME is public static. I'd think you'd want to hide these 
machinations at least inside the package if not make these calls private. 

FYI, this call is expensive: i.e. HBaseConfiguration.create(). I suppose it 
hard getting a Configuration in here otherwise. Is suppose it ok if once per 
process....

> Add support for specifying custom meta table suffix
> ---------------------------------------------------
>
>                 Key: HBASE-18444
>                 URL: https://issues.apache.org/jira/browse/HBASE-18444
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0, 1.3.1
>            Reporter: Ajay Jadhav
>            Assignee: Ajay Jadhav
>              Labels: patch
>         Attachments: HBASE-18444.branch-1.001.patch, 
> HBASE-18444.master.001.patch
>
>
> This patch provides user an ability to have a custom meta table suffix.
> In order to share a common rootDir amongst multiple HBase clusters, we need 
> separate meta table for each cluster.
> With custom meta table suffix, the meta table is named in the form of 
> meta_{suffix} making it specific to a cluster.
> Users can specify the meta table suffix as part of hbase-site.xml.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to