[
https://issues.apache.org/jira/browse/HBASE-5199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188715#comment-13188715
]
Phabricator commented on HBASE-5199:
------------------------------------
Karthik has commented on the revision "[jira][HBASE-5199] Delete out of TTL
store files before compaction selection ".
Havent reviewed the test code yet...
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/regionserver/Store.java:1039 Do we need
this assignment? Can we make the condition:
if (nonExpiredFiles.size() < currentStoreFiles.size()) {
//...
}
src/main/java/org/apache/hadoop/hbase/regionserver/Store.java:1017 Should we
exclude files contained in filesCompacting? Otherwise we could end up deleting
a file which is currently being compacted...
REVISION DETAIL
https://reviews.facebook.net/D1311
> Delete out of TTL store files before compaction selection
> ---------------------------------------------------------
>
> Key: HBASE-5199
> URL: https://issues.apache.org/jira/browse/HBASE-5199
> Project: HBase
> Issue Type: Improvement
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D1311.1.patch
>
>
> Currently, HBase deletes the out of TTL store files after compaction. We can
> change the sequence to delete the out of TTL store files before selecting
> store files for compactions.
> In this way, HBase can keep deleting the old invalid store files without
> compaction, and also prevent from unnecessary compactions since the out of
> TTL store files will be deleted before the compaction selection.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
