[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226195#comment-16226195
]
stack edited comment on HBASE-18770 at 10/31/17 3:47 AM:
---------------------------------------------------------
On a read-only WALKey, I think I'll skip. It is yet another object creation on
the write-path or if I were to make WALKey into an Interface of read-only
methods, it is a bunch of work given WALKey is serialized to HFiles up to this.
This WALKey as-is we want to take internal for hbase3 at least and probably
redo since its so fat. WALKey is already IA.Private.
A CP could try setting compression context, original sequence id (needed at WAL
Replay time), and replication scope can be edited as the WAL Key is replicated
to different peers. I added a warning on each CP method that WALKey should not
be modified
[~chia7712] Let me know if this ok. I could file a follow-on and schedule it
for beta-1.
was (Author: stack):
On a read-only WALKey, I think I'll skip. It is yet another object creation on
the write-path or if I were to make WALKey into an Interface of read-only
methods, it is a bunch of work given WALKey is serialized to HFiles up to this.
This WALKey as-is we want to take internal for hbase3 at least and probably
redo since its so fat. WALKey is already IA.Private.
A CP could try setting compression context, original sequence id (needed at WAL
Replay time), and replication scope can be edited as the WAL Key is replicated
to different peers. I added a warning on each CP method that WALKey should not
be modified.
> Remove bypass method in ObserverContext and implement the 'bypass' logic case
> by case
> -------------------------------------------------------------------------------------
>
> Key: HBASE-18770
> URL: https://issues.apache.org/jira/browse/HBASE-18770
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
> Reporter: Duo Zhang
> Assignee: stack
> Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18770.master.001.patch,
> HBASE-18770.master.002.patch, HBASE-18770.master.003.patch,
> HBASE-18770.master.004.patch, HBASE-18770.master.005.patch,
> HBASE-18770.master.006.patch, HBASE-18770.master.007.patch,
> HBASE-18770.master.008.patch, HBASE-18770.master.009.patch,
> HBASE-18770.master.010.patch, HBASE-18770.master.011.patch
>
>
> http://search-hadoop.com/m/HBase/YGbbXd0RDCIHSC1
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
