[ 
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227391#comment-16227391
 ] 

stack edited comment on HBASE-18770 at 10/31/17 7:48 PM:
---------------------------------------------------------

Looks like the patch passed in all but checkstyle.....  Going to commit.

{code}
...
16:54:32 -1 overall
16:54:32 
16:54:32 | Vote |       Subsystem |  Runtime   | Comment
16:54:32 
============================================================================
16:54:32 |   0  |         reexec  |   2m 17s   | Docker mode activated. 
16:54:32 |      |                 |            | Prechecks 
16:54:32 |   0  |       findbugs  |   0m  0s   | Findbugs executables are not 
available. 
16:54:32 |  +1  |      hbaseanti  |   0m  0s   | Patch does not have any 
anti-patterns. 
16:54:32 |  +1  |        @author  |   0m  0s   | The patch does not contain any 
@author 
16:54:32 |      |                 |            | tags.
16:54:32 |  +1  |     test4tests  |   0m  0s   | The patch appears to include 5 
new or 
16:54:32 |      |                 |            | modified test files.
16:54:32 |      |                 |            | master Compile Tests 
16:54:32 |   0  |         mvndep  |   0m 12s   | Maven dependency ordering for 
branch 
16:54:32 |  +1  |     mvninstall  |   4m 27s   | master passed 
16:54:32 |  +1  |        compile  |   1m 20s   | master passed 
16:54:32 |  +1  |     checkstyle  |   1m 57s   | master passed 
16:54:32 |  +1  |     shadedjars  |   6m 33s   | branch has no errors when 
building our 
16:54:32 |      |                 |            | shaded downstream artifacts.
16:54:32 |  +1  |        javadoc  |   0m 56s   | master passed 
16:54:32 |      |                 |            | Patch Compile Tests 
16:54:32 |   0  |         mvndep  |   0m 13s   | Maven dependency ordering for 
patch 
16:54:32 |  +1  |     mvninstall  |   4m 26s   | the patch passed 
16:54:32 |  +1  |        compile  |   1m 20s   | the patch passed 
16:54:32 |  +1  |          javac  |   1m 20s   | the patch passed 
16:54:32 |  -1  |     checkstyle  |   1m 18s   | hbase-server: The patch 
generated 65 
16:54:32 |      |                 |            | new + 1044 unchanged - 88 
fixed = 1109
16:54:32 |      |                 |            | total (was 1132)
16:54:32 |  +1  |     whitespace  |   0m  0s   | The patch has no whitespace 
issues. 
16:54:32 |  +1  |     shadedjars  |   4m 39s   | patch has no errors when 
building our 
16:54:32 |      |                 |            | shaded downstream artifacts.
16:54:32 |  +1  |    hadoopcheck  |  46m 27s   | Patch does not cause any 
errors with 
16:54:32 |      |                 |            | Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 
2.6.5
16:54:32 |      |                 |            | 2.7.1 2.7.2 2.7.3 or 
3.0.0-alpha4.
16:54:32 |  +1  |        javadoc  |   0m 56s   | the patch passed 
16:54:32 |      |                 |            | Other Tests 
16:54:32 |  +1  |           unit  |   2m 29s   | hbase-client in the patch 
passed. 
16:54:32 |  +1  |           unit  |  95m 27s   | hbase-server in the patch 
passed. 
16:54:32 |  +1  |           unit  |   3m 13s   | hbase-endpoint in the patch 
passed. 
16:54:32 |  +1  |     asflicense  |   0m 49s   | The patch does not generate 
ASF License 
16:54:32 |      |                 |            | warnings.
16:54:32 |      |                 | 173m 34s   | 
16:54:32 
16:54:32 
16:54:32 || Subsystem || Report/Notes ||
16:54:32 
============================================================================
16:54:32 | Docker | Client=17.05.0-ce Server=17.05.0-ce 
Image:yetus/hbase:eee3b01 |
16:54:32 | JIRA Issue | HBASE-18770 |
16:54:32 | JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12894987/HBASE-18770.master.012.patch
 |
16:54:32 | Optional Tests |  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
16:54:32 | uname | Linux 843dfac0213b 3.13.0-129-generic #178-Ubuntu SMP Fri 
Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux |
16:54:32 | Build tool | maven |
16:54:32 | Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
16:54:32 | git revision | master / bbb7e1924d |
16:54:32 | Default Java | 1.8.0_141 |
16:54:32 | checkstyle | /testptch/patchprocess/diff-checkstyle-hbase-server.txt 
|
16:54:32 |  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9536/testReport/ |
16:54:33 | modules | C: hbase-client hbase-server hbase-endpoint U: . |
16:54:33 | Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9536/console |
16:54:33 | Powered by | Apache Yetus 0.5.0   http://yetus.apache.org |
16:54:33 
16:54:33 
16:54:33 
============================================================================
16:54:33 
============================================================================
16:54:33                               Finished build.
16:54:33 
============================================================================
16:54:33 
============================================================================
...
{code}


https://builds.apache.org/view/H-L/view/HBase/job/PreCommit-HBASE-Build/9536/console


was (Author: stack):
Looks like the patch passed in all but checkstyle.....  Going to commit.

{code}
...
16:54:32 -1 overall
16:54:32 
16:54:32 | Vote |       Subsystem |  Runtime   | Comment
16:54:32 
============================================================================
16:54:32 |   0  |         reexec  |   2m 17s   | Docker mode activated. 
16:54:32 |      |                 |            | Prechecks 
16:54:32 |   0  |       findbugs  |   0m  0s   | Findbugs executables are not 
available. 
16:54:32 |  +1  |      hbaseanti  |   0m  0s   | Patch does not have any 
anti-patterns. 
16:54:32 |  +1  |        @author  |   0m  0s   | The patch does not contain any 
@author 
16:54:32 |      |                 |            | tags.
16:54:32 |  +1  |     test4tests  |   0m  0s   | The patch appears to include 5 
new or 
16:54:32 |      |                 |            | modified test files.
16:54:32 |      |                 |            | master Compile Tests 
16:54:32 |   0  |         mvndep  |   0m 12s   | Maven dependency ordering for 
branch 
16:54:32 |  +1  |     mvninstall  |   4m 27s   | master passed 
16:54:32 |  +1  |        compile  |   1m 20s   | master passed 
16:54:32 |  +1  |     checkstyle  |   1m 57s   | master passed 
16:54:32 |  +1  |     shadedjars  |   6m 33s   | branch has no errors when 
building our 
16:54:32 |      |                 |            | shaded downstream artifacts.
16:54:32 |  +1  |        javadoc  |   0m 56s   | master passed 
16:54:32 |      |                 |            | Patch Compile Tests 
16:54:32 |   0  |         mvndep  |   0m 13s   | Maven dependency ordering for 
patch 
16:54:32 |  +1  |     mvninstall  |   4m 26s   | the patch passed 
16:54:32 |  +1  |        compile  |   1m 20s   | the patch passed 
16:54:32 |  +1  |          javac  |   1m 20s   | the patch passed 
16:54:32 |  -1  |     checkstyle  |   1m 18s   | hbase-server: The patch 
generated 65 
16:54:32 |      |                 |            | new + 1044 unchanged - 88 
fixed = 1109
16:54:32 |      |                 |            | total (was 1132)
16:54:32 |  +1  |     whitespace  |   0m  0s   | The patch has no whitespace 
issues. 
16:54:32 |  +1  |     shadedjars  |   4m 39s   | patch has no errors when 
building our 
16:54:32 |      |                 |            | shaded downstream artifacts.
16:54:32 |  +1  |    hadoopcheck  |  46m 27s   | Patch does not cause any 
errors with 
16:54:32 |      |                 |            | Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 
2.6.5
16:54:32 |      |                 |            | 2.7.1 2.7.2 2.7.3 or 
3.0.0-alpha4.
16:54:32 |  +1  |        javadoc  |   0m 56s   | the patch passed 
16:54:32 |      |                 |            | Other Tests 
16:54:32 |  +1  |           unit  |   2m 29s   | hbase-client in the patch 
passed. 
16:54:32 |  +1  |           unit  |  95m 27s   | hbase-server in the patch 
passed. 
16:54:32 |  +1  |           unit  |   3m 13s   | hbase-endpoint in the patch 
passed. 
16:54:32 |  +1  |     asflicense  |   0m 49s   | The patch does not generate 
ASF License 
16:54:32 |      |                 |            | warnings.
16:54:32 |      |                 | 173m 34s   | 
16:54:32 
16:54:32 
16:54:32 || Subsystem || Report/Notes ||
16:54:32 
============================================================================
16:54:32 | Docker | Client=17.05.0-ce Server=17.05.0-ce 
Image:yetus/hbase:eee3b01 |
16:54:32 | JIRA Issue | HBASE-18770 |
16:54:32 | JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12894987/HBASE-18770.master.012.patch
 |
16:54:32 | Optional Tests |  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
16:54:32 | uname | Linux 843dfac0213b 3.13.0-129-generic #178-Ubuntu SMP Fri 
Aug 11 12:48:20 UTC 2017 x86_64 GNU/Linux |
16:54:32 | Build tool | maven |
16:54:32 | Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
16:54:32 | git revision | master / bbb7e1924d |
16:54:32 | Default Java | 1.8.0_141 |
16:54:32 | checkstyle | /testptch/patchprocess/diff-checkstyle-hbase-server.txt 
|
16:54:32 |  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9536/testReport/ |
16:54:33 | modules | C: hbase-client hbase-server hbase-endpoint U: . |
16:54:33 | Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/9536/console |
16:54:33 | Powered by | Apache Yetus 0.5.0   http://yetus.apache.org |
16:54:33 
16:54:33 
16:54:33 
============================================================================
16:54:33 
============================================================================
16:54:33                               Finished build.
16:54:33 
============================================================================
16:54:33 
============================================================================
...
{code}

> Remove bypass method in ObserverContext and implement the 'bypass' logic case 
> by case
> -------------------------------------------------------------------------------------
>
>                 Key: HBASE-18770
>                 URL: https://issues.apache.org/jira/browse/HBASE-18770
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: Duo Zhang
>            Assignee: stack
>            Priority: Critical
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-18770.master.001.patch, 
> HBASE-18770.master.002.patch, HBASE-18770.master.003.patch, 
> HBASE-18770.master.004.patch, HBASE-18770.master.005.patch, 
> HBASE-18770.master.006.patch, HBASE-18770.master.007.patch, 
> HBASE-18770.master.008.patch, HBASE-18770.master.009.patch, 
> HBASE-18770.master.010.patch, HBASE-18770.master.011.patch, 
> HBASE-18770.master.012.patch
>
>
> http://search-hadoop.com/m/HBase/YGbbXd0RDCIHSC1



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to