[
https://issues.apache.org/jira/browse/HBASE-19367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272231#comment-16272231
]
Appy commented on HBASE-19367:
------------------------------
Wohoo...
Committing to master and branch-2. Will fix 4/5 checkstyles issues on commit.
The last one is preexisting and i don't want to touch right now (requires
changing loop).
Thanks for review [~stack].
> Refactoring in RegionStates, and RSProcedureDispatcher
> ------------------------------------------------------
>
> Key: HBASE-19367
> URL: https://issues.apache.org/jira/browse/HBASE-19367
> Project: HBase
> Issue Type: Improvement
> Reporter: Appy
> Assignee: Appy
> Priority: Minor
> Attachments: HBASE-19367.master.001.patch,
> HBASE-19367.master.002.patch, HBASE-19367.master.003.patch,
> HBASE-19367.master.004.patch
>
>
> Working on a bug fix, was in these parts for first time to understand new AM
> and trying to make sense of things. Did a few improvements on the way.
> - Adding javadoc comments
> - Bug: ServerStateNode#regions is HashSet but there's no synchronization to
> prevent concurrent addRegion/removeRegion. Let's use concurrent set instead.
> - Use getRegionsInTransitionCount() directly to avoid instead of
> getRegionsInTransition().size() because the latter copies everything into a
> new array - what a waste for just the size.
> - There's mixed use of getRegionNode and getRegionStateNode for same return
> type - RegionStateNode. Changing everything to getRegionStateNode. Similarly
> rename other *RegionNode() fns to *RegionStateNode().
> - RegionStateNode#transitionState() return value is useless since it always
> returns it's first param.
> - Other minor improvements
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
