[ https://issues.apache.org/jira/browse/HBASE-19367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272604#comment-16272604 ]
Hudson commented on HBASE-19367: -------------------------------- SUCCESS: Integrated in Jenkins build HBase-2.0 #941 (See [https://builds.apache.org/job/HBase-2.0/941/]) HBASE-19367 Refactoring in RegionStates, and RSProcedureDispatcher (appy: rev 4f4aac77e1f2ff3b552bfa70ec64a1fc45110b6d) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java * (edit) hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsOfflineMode.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestRegionInfoDisplay.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/MetaTableLocator.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignProcedure.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/master/RegionState.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateStore.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java * (edit) hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RemoteProcedureDispatcher.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionTransitionProcedure.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionStates.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterBalanceThrottling.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionState.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/MockMasterServices.java > Refactoring in RegionStates, and RSProcedureDispatcher > ------------------------------------------------------ > > Key: HBASE-19367 > URL: https://issues.apache.org/jira/browse/HBASE-19367 > Project: HBase > Issue Type: Improvement > Reporter: Appy > Assignee: Appy > Priority: Minor > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19367.master.001.patch, > HBASE-19367.master.002.patch, HBASE-19367.master.003.patch, > HBASE-19367.master.004.patch > > > Working on a bug fix, was in these parts for first time to understand new AM > and trying to make sense of things. Did a few improvements on the way. > - Adding javadoc comments > - Bug: ServerStateNode#regions is HashSet but there's no synchronization to > prevent concurrent addRegion/removeRegion. Let's use concurrent set instead. > - Use getRegionsInTransitionCount() directly to avoid instead of > getRegionsInTransition().size() because the latter copies everything into a > new array - what a waste for just the size. > - There's mixed use of getRegionNode and getRegionStateNode for same return > type - RegionStateNode. Changing everything to getRegionStateNode. Similarly > rename other *RegionNode() fns to *RegionStateNode(). > - RegionStateNode#transitionState() return value is useless since it always > returns it's first param. > - Other minor improvements -- This message was sent by Atlassian JIRA (v6.4.14#64029)