[ 
https://issues.apache.org/jira/browse/HBASE-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195762#comment-13195762
 ] 

Phabricator commented on HBASE-5186:
------------------------------------

tedyu has commented on the revision "HBASE-5186 [jira] Add metrics to 
ThriftServer".

  Methods in class CallQueue look packed.
  Usually we leave one empty line between methods.

REVISION DETAIL
  https://reviews.facebook.net/D1461

                
> Add metrics to ThriftServer
> ---------------------------
>
>                 Key: HBASE-5186
>                 URL: https://issues.apache.org/jira/browse/HBASE-5186
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>         Attachments: HBASE-5186.D1461.1.patch, HBASE-5186.D1461.2.patch, 
> HBASE-5186.D1461.3.patch, HBASE-5186.D1461.4.patch, HBASE-5186.D1461.5.patch
>
>
> It will be useful to have some metrics (queue length, waiting time, 
> processing time ...) similar to Hadoop RPC server. This allows us to monitor 
> system health also provide a tool to diagnose the problem where thrift calls 
> are slow.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to