[ https://issues.apache.org/jira/browse/HBASE-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196906#comment-13196906 ]
Phabricator commented on HBASE-5186: ------------------------------------ sc has commented on the revision "HBASE-5186 [jira] Add metrics to ThriftServer". INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/thrift/CallQueue.java:67 I am not sure if we should check startTime. One might want to remove a Runnable added to the CallQueue (which is a BlockingQueue<Runnable>). Adding the startTime check will remove this ability. REVISION DETAIL https://reviews.facebook.net/D1461 > Add metrics to ThriftServer > --------------------------- > > Key: HBASE-5186 > URL: https://issues.apache.org/jira/browse/HBASE-5186 > Project: HBase > Issue Type: Improvement > Reporter: Scott Chen > Assignee: Scott Chen > Attachments: HBASE-5186.D1461.1.patch, HBASE-5186.D1461.2.patch, > HBASE-5186.D1461.3.patch, HBASE-5186.D1461.4.patch, HBASE-5186.D1461.5.patch, > HBASE-5186.D1461.6.patch, HBASE-5186.D1461.7.patch > > > It will be useful to have some metrics (queue length, waiting time, > processing time ...) similar to Hadoop RPC server. This allows us to monitor > system health also provide a tool to diagnose the problem where thrift calls > are slow. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira