[
https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16290650#comment-16290650
]
Anoop Sam John commented on HBASE-19112:
----------------------------------------
bq.So is it ok to have both getTypeByte and getType in ExtendedCell?
I too think this is ok. +1 for that.
There is one more Q
The server side code still has to work only with getTypeByte(). getType is only
for the client side expose. And the fake cells will always throw Exception on
getType() call. So we would never be able to use that in our server side
compares and ops.
Also on a side note, the CP users can create Cells and pass us right? I think
the hooks like prePut() can allow CP users to do this. These cell impls also
has to impl the getTypeByte(). Means the getTypeByte() to be in RawCell not
just in ExtendedCell. The latter is not exposed at all. This is not specific
to this type.. Kind of a generic Q. Or else we have to have the type check and
if Cell is ExtnededCell type, make use of the getTypeByte() API directly. Else
convert the getType Enum into a type byte.
> Suspect methods on Cell to be deprecated
> ----------------------------------------
>
> Key: HBASE-19112
> URL: https://issues.apache.org/jira/browse/HBASE-19112
> Project: HBase
> Issue Type: Bug
> Components: Client
> Reporter: Josh Elser
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19112_branch-2.patch,
> HBASE-19112_branch-2_1.patch, HBASE-19112_master.patch,
> HBASE-19112_master_1.patch, HBASE-19112_master_1.patch
>
>
> [~chia7712] suggested on the [mailing
> list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
> that we have some methods on Cell which should be deprecated for removal:
> * {{#getType()}}
> * {{#getTimestamp()}}
> * {{#getTag()}}
> * {{#getSequenceId()}}
> Let's make a pass over these (and maybe the rest) to make sure that there
> aren't others which are either implementation details or methods returning
> now-private-marked classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
