[
https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292044#comment-16292044
]
Anoop Sam John commented on HBASE-19112:
----------------------------------------
I was not suggesting we should allow adding custom cells in CP. I was just
asking if they add. Just for open thinking. Ya the arg seems fine.
Good point by Ram on the client side CellComparator usage. Ya this will
definitely be an issue if the custom cells are added. So Put#add() should take
a Cell impl created by the Builder. There we know what type we makes. Then my
Q will be like why to have Put#add(Cell)? That cell has to be created using a
fixed API in CellBuilder. May be a better way to restrict user from adding
custom Cells. I would say 99.9% users might not do this way but will create
Cell using the builder only . But just asking to unearth any better for us.
bq. they must to add ExtendedCell since the RS need to update cell's timestamp
and sequence id
Good point. Seems some methods in ExtendedCell has to be moved to RawCell. Ya
setTs and seqId things must be there. Remembering now that SettableTimeStamp
and other interface were CP exposed for this reason. May be do this as another
issue?
> Suspect methods on Cell to be deprecated
> ----------------------------------------
>
> Key: HBASE-19112
> URL: https://issues.apache.org/jira/browse/HBASE-19112
> Project: HBase
> Issue Type: Bug
> Components: Client
> Reporter: Josh Elser
> Assignee: ramkrishna.s.vasudevan
> Priority: Blocker
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19112_branch-2.patch,
> HBASE-19112_branch-2_1.patch, HBASE-19112_master.patch,
> HBASE-19112_master_1.patch, HBASE-19112_master_1.patch,
> HBASE-19112_master_2.patch
>
>
> [~chia7712] suggested on the [mailing
> list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
> that we have some methods on Cell which should be deprecated for removal:
> * {{#getType()}}
> * {{#getTimestamp()}}
> * {{#getTag()}}
> * {{#getSequenceId()}}
> Let's make a pass over these (and maybe the rest) to make sure that there
> aren't others which are either implementation details or methods returning
> now-private-marked classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
